kunthawat/ALwrity
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Add committee health precheck and orchestrator init state metadata

Browse Source
This commit is contained in:
ي
2026-03-06 21:40:03 +05:30
parent 5d49351c2d
commit 15a9eaa9a0
2 changed files with 201 additions and 68 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
backend/services/intelligence/agents/agent_orchestrator.py
View File

@@ -464,6 +464,7 @@ class AgentOrchestrationService:
async def get_or_create_orchestrator(self, user_id: str) -> ALwrityAgentOrchestrator: async def get_or_create_orchestrator(self, user_id: str) -> ALwrityAgentOrchestrator:
"""Get or create an orchestrator for a user""" """Get or create an orchestrator for a user"""
onboarding_gated_initialization = False
if user_id not in self.orchestrators: if user_id not in self.orchestrators:
config = AgentTeamConfiguration(user_id=user_id) config = AgentTeamConfiguration(user_id=user_id)
self.orchestrators[user_id] = ALwrityAgentOrchestrator(config) self.orchestrators[user_id] = ALwrityAgentOrchestrator(config)
@@ -475,6 +476,25 @@ class AgentOrchestrationService:
logger.info(f"Orchestrator for {user_id} has no agents. Attempting re-initialization.") logger.info(f"Orchestrator for {user_id} has no agents. Attempting re-initialization.")
orchestrator._create_specialized_agents() orchestrator._create_specialized_agents()
last_system_check = next(
(
entry
for entry in reversed(orchestrator.execution_history)
if entry.get("action") == "system_check"
),
None,
)
if last_system_check and last_system_check.get("status") == "pending":
details = str(last_system_check.get("details") or "").lower()
onboarding_gated_initialization = "onboarding" in details
orchestrator.onboarding_gated_initialization = onboarding_gated_initialization
orchestrator.initialization_state = {
"onboarding_gated_initialization": onboarding_gated_initialization,
"active_agent_count": len(orchestrator.agents),
"active_agent_keys": sorted(orchestrator.agents.keys()),
}
return orchestrator return orchestrator
async def execute_marketing_strategy(self, user_id: str, market_context: Dict[str, Any]) -> Dict[str, Any]: async def execute_marketing_strategy(self, user_id: str, market_context: Dict[str, Any]) -> Dict[str, Any]:

231
backend/services/today_workflow_service.py
View File

@@ -276,85 +276,147 @@ async def generate_agent_enhanced_plan(db: Session, user_id: str, date: str) ->
activity = AgentActivityService(db, user_id) activity = AgentActivityService(db, user_id)
grounding = build_grounding_context(db, user_id, date) grounding = build_grounding_context(db, user_id, date)
memory_service = TaskMemoryService(user_id, db) memory_service = TaskMemoryService(user_id, db)
min_active_agents = 2
generation_path = "committee"
# 1. Get Orchestrator # 1. Get Orchestrator
try: try:
orchestrator = await orchestration_service.get_or_create_orchestrator(user_id) orchestrator = await orchestration_service.get_or_create_orchestrator(user_id)
except Exception as e: except Exception as e:
logger.error(f"Failed to get orchestrator: {e}") logger.error(f"Failed to get orchestrator: {e}")
return {"date": date, "tasks": _fallback_tasks(date)} fallback_tasks = _ensure_pillar_coverage(_fallback_tasks(date), user_id, date, grounding)
return {
"date": date,
"tasks": fallback_tasks,
"metadata": {
"generation_path": "controlled_fallback",
"committee": {
"minimum_active_agents": min_active_agents,
"active_agents": {"count": 0, "names": []},
},
"degraded": {
"is_degraded": True,
"reason": "orchestrator_unavailable",
"missing_agents": [],
},
},
}
expected_committee_agents = ["content", "strategy", "seo", "social", "competitor"]
active_agent_names = sorted(orchestrator.agents.keys())
active_agents_count = len(active_agent_names)
missing_agents = [name for name in expected_committee_agents if name not in active_agent_names]
onboarding_gated_initialization = bool(getattr(orchestrator, "onboarding_gated_initialization", False))
initialization_state = (
getattr(orchestrator, "initialization_state", None)
if isinstance(getattr(orchestrator, "initialization_state", None), dict)
else {}
)
degraded_metadata = {
"is_degraded": False,
"reason": None,
"missing_agents": [],
}
if active_agents_count < min_active_agents:
generation_path = "controlled_fallback"
degraded_metadata = {
"is_degraded": True,
"reason": "insufficient_active_agents",
"missing_agents": missing_agents,
}
activity.log_event(
event_type="committee_health",
severity="warning",
message="Committee degraded: insufficient active agents",
payload=build_agent_event_payload(
phase="planning",
step="committee_health_precheck",
progress_percent=5,
output_summary=f"Only {active_agents_count} active committee agents",
decision_reason="Agent committee below configured minimum",
evidence_refs=active_agent_names,
safe_debug=True,
metadata={
"minimum_active_agents": min_active_agents,
"active_agents": {
"count": active_agents_count,
"names": active_agent_names,
},
"missing_agents": missing_agents,
"onboarding_gated_initialization": onboarding_gated_initialization,
"orchestrator_initialization_state": initialization_state,
},
),
agent_type="TodayWorkflowGenerator",
)
# 2. Parallel "Committee" Proposal Gathering # 2. Parallel "Committee" Proposal Gathering
logger.info(f"Gathering daily task proposals from agent committee for user {user_id}") logger.info(f"Gathering daily task proposals from agent committee for user {user_id}")
agent_tasks = [] agent_tasks = []
try: if generation_path == "committee":
# Define agents to poll try:
agents_to_poll = [ # Define agents to poll
orchestrator.agents.get('content'), # ContentStrategyAgent agents_to_poll = [
orchestrator.agents.get('strategy'), # StrategyArchitectAgent orchestrator.agents.get('content'), # ContentStrategyAgent
orchestrator.agents.get('seo'), # SEOOptimizationAgent orchestrator.agents.get('strategy'), # StrategyArchitectAgent
orchestrator.agents.get('social'), # SocialAmplificationAgent orchestrator.agents.get('seo'), # SEOOptimizationAgent
orchestrator.agents.get('competitor'), # CompetitorResponseAgent orchestrator.agents.get('social'), # SocialAmplificationAgent
] orchestrator.agents.get('competitor'), # CompetitorResponseAgent
]
# Filter out None agents (disabled/failed init) # Filter out None agents (disabled/failed init)
active_agents = [a for a in agents_to_poll if a] active_agents = [a for a in agents_to_poll if a]
# Execute propose_daily_tasks in parallel # Execute propose_daily_tasks in parallel
results = await asyncio.gather( results = await asyncio.gather(
*[a.propose_daily_tasks(grounding) for a in active_agents], *[a.propose_daily_tasks(grounding) for a in active_agents],
return_exceptions=True return_exceptions=True
) )
# Collect successful proposals # Collect successful proposals
raw_proposals = [] raw_proposals = []
for res in results: for res in results:
if isinstance(res, list): if isinstance(res, list):
raw_proposals.extend(res) raw_proposals.extend(res)
elif isinstance(res, Exception): elif isinstance(res, Exception):
logger.warning(f"Agent proposal failed: {res}") logger.warning(f"Agent proposal failed: {res}")
# 3. Filter Redundant Proposals (Self-Learning) # Simple deduplication based on title+pillar
# Note: We need to ensure we don't filter out essential recurring tasks if they were completed long ago unique_map = {}
# But for now, we filter exact duplicates from recent history (last 7 days) for p in raw_proposals:
# We can implement semantic filtering later key = f"{p.pillar_id}:{p.title}"
if key not in unique_map:
unique_map[key] = p
continue
# Simple deduplication based on title+pillar existing = unique_map[key]
unique_map = {} if _proposal_priority_rank(p.priority) > _proposal_priority_rank(existing.priority):
for p in raw_proposals: unique_map[key] = p
key = f"{p.pillar_id}:{p.title}" continue
if key not in unique_map:
unique_map[key] = p
continue
existing = unique_map[key] # Deterministic tie-breaker for equal priority proposals.
if _proposal_priority_rank(p.priority) > _proposal_priority_rank(existing.priority): if (
unique_map[key] = p _proposal_priority_rank(p.priority) == _proposal_priority_rank(existing.priority)
continue and _proposal_order_key(p) < _proposal_order_key(existing)
):
unique_map[key] = p
# Deterministic tie-breaker for equal priority proposals. agent_tasks = list(unique_map.values())
if (
_proposal_priority_rank(p.priority) == _proposal_priority_rank(existing.priority)
and _proposal_order_key(p) < _proposal_order_key(existing)
):
unique_map[key] = p
agent_tasks = list(unique_map.values()) # Check memory for rejections (semantic filter)
agent_tasks = await memory_service.filter_redundant_proposals(agent_tasks)
# Phase 3: Check memory for rejections (Semantic Filter) except Exception as e:
agent_tasks = await memory_service.filter_redundant_proposals(agent_tasks) logger.error(f"Committee proposal phase failed: {e}")
generation_path = "llm_fallback"
except Exception as e: # 3. Final Selection
logger.error(f"Committee proposal phase failed: {e}") if generation_path == "committee" and agent_tasks:
# Continue to fallback or LLM generation if committee fails
# 4. Final Selection
# If we have agent tasks, use them. Otherwise fall back to LLM generation.
if agent_tasks:
logger.info(f"Generated {len(agent_tasks)} tasks via Agent Committee") logger.info(f"Generated {len(agent_tasks)} tasks via Agent Committee")
# Convert TaskProposal objects to dicts for frontend
final_tasks = [] final_tasks = []
for prop in agent_tasks: for prop in agent_tasks:
final_tasks.append({ final_tasks.append({
@@ -376,10 +438,46 @@ async def generate_agent_enhanced_plan(db: Session, user_id: str, date: str) ->
final_tasks = _ensure_pillar_coverage(final_tasks, user_id, date, grounding) final_tasks = _ensure_pillar_coverage(final_tasks, user_id, date, grounding)
return { return {
"date": date, "date": date,
"tasks": final_tasks "tasks": final_tasks,
"metadata": {
"generation_path": "committee",
"committee": {
"minimum_active_agents": min_active_agents,
"active_agents": {
"count": active_agents_count,
"names": active_agent_names,
},
"onboarding_gated_initialization": onboarding_gated_initialization,
"orchestrator_initialization_state": initialization_state,
},
"degraded": degraded_metadata,
},
} }
# Fallback to original LLM generation if agents returned nothing if generation_path != "controlled_fallback":
generation_path = "llm_fallback"
if generation_path == "controlled_fallback":
fallback_tasks = _ensure_pillar_coverage(_fallback_tasks(date), user_id, date, grounding)
return {
"date": date,
"tasks": fallback_tasks,
"metadata": {
"generation_path": "controlled_fallback",
"committee": {
"minimum_active_agents": min_active_agents,
"active_agents": {
"count": active_agents_count,
"names": active_agent_names,
},
"onboarding_gated_initialization": onboarding_gated_initialization,
"orchestrator_initialization_state": initialization_state,
},
"degraded": degraded_metadata,
},
}
# Fallback to original LLM generation if committee returned nothing
logger.info("Agent committee returned no tasks, falling back to LLM generation") logger.info("Agent committee returned no tasks, falling back to LLM generation")
schema = { schema = {
@@ -457,17 +555,32 @@ async def generate_agent_enhanced_plan(db: Session, user_id: str, date: str) ->
tasks = result.get("tasks") if isinstance(result, dict) else None tasks = result.get("tasks") if isinstance(result, dict) else None
if not isinstance(tasks, list) or not tasks: if not isinstance(tasks, list) or not tasks:
generation_path = "controlled_fallback"
tasks = _fallback_tasks(date) tasks = _fallback_tasks(date)
result = { result = {
"date": date, "date": date,
"tasks": _ensure_pillar_coverage(tasks, user_id, date, grounding), "tasks": _ensure_pillar_coverage(tasks, user_id, date, grounding),
"metadata": {
"generation_path": generation_path,
"committee": {
"minimum_active_agents": min_active_agents,
"active_agents": {
"count": active_agents_count,
"names": active_agent_names,
},
"onboarding_gated_initialization": onboarding_gated_initialization,
"orchestrator_initialization_state": initialization_state,
},
"degraded": degraded_metadata,
},
} }
activity.log_event( activity.log_event(
event_type="final_summary", event_type="final_summary",
severity="info", severity="info",
message="Daily workflow plan generated", message="Daily workflow plan generated",
payload=build_agent_event_payload(phase="generation", step="workflow_generated", tool_name="llm_text_gen", progress_percent=100, output_summary=f"Generated {len(result.get('tasks', []))} tasks", decision_reason="Workflow assembled successfully", evidence_refs=[date], safe_debug=True, metadata={"date": date, "task_count": len(result.get("tasks", []))}), payload=build_agent_event_payload(phase="generation", step="workflow_generated", tool_name="llm_text_gen", progress_percent=100, output_summary=f"Generated {len(result.get('tasks', []))} tasks", decision_reason="Workflow assembled successfully", evidence_refs=[date], safe_debug=True, metadata={"date": date, "task_count": len(result.get("tasks", [])), "generation_path": generation_path}),
run_id=run.id, run_id=run.id,
agent_type="TodayWorkflowGenerator", agent_type="TodayWorkflowGenerator",
) )