From 5f066b6c0ed75ac467978bd59a495c01d2d2bc35 Mon Sep 17 00:00:00 2001
From: ajaysi <ajay.calsoft@gmail.com>
Date: Sat, 11 Oct 2025 18:08:10 +0530
Subject: [PATCH] Add robust fallback logic for Step 3 data passing

- Check multiple storage sources for website URL (props, localStorage, sessionStorage)
- Add validation to prevent API calls without website URL
- Improve debugging logs to track data flow
- Make CompetitorAnalysisStep more resilient to production edge cases
- No breaking changes, just defensive improvements
---
 .../CompetitorAnalysisStep.tsx                | 50 ++++++++++++++++---
 .../components/OnboardingWizard/Wizard.tsx    |  2 +-
 2 files changed, 44 insertions(+), 8 deletions(-)

diff --git a/frontend/src/components/OnboardingWizard/CompetitorAnalysisStep.tsx b/frontend/src/components/OnboardingWizard/CompetitorAnalysisStep.tsx
index 7bc392ec..285fbd8b 100644
--- a/frontend/src/components/OnboardingWizard/CompetitorAnalysisStep.tsx
+++ b/frontend/src/components/OnboardingWizard/CompetitorAnalysisStep.tsx
@@ -154,15 +154,46 @@ const CompetitorAnalysisStep: React.FC<CompetitorAnalysisStepProps> = ({
       setAnalysisProgress(80);
       await new Promise(resolve => setTimeout(resolve, 1000));
 
-      // Get website URL from props or localStorage
-      const finalUserUrl = userUrl || localStorage.getItem('website_url') || '';
+      // Get website URL from multiple sources with better fallbacks
+      const propUserUrl = userUrl || '';
+      const localStorageUrl = localStorage.getItem('website_url') || '';
+      const sessionStorageUrl = sessionStorage.getItem('website_url') || '';
       
-      // Get website analysis data from localStorage or step data
-      const websiteAnalysisData = localStorage.getItem('website_analysis_data') 
-        ? JSON.parse(localStorage.getItem('website_analysis_data')!) 
-        : null;
+      // Try to get from onboarding context or global state
+      const onboardingContextUrl = (window as any).onboardingContext?.websiteUrl || '';
       
-      console.log('CompetitorAnalysisStep: Final URL to use:', finalUserUrl);
+      const finalUserUrl = propUserUrl || localStorageUrl || sessionStorageUrl || onboardingContextUrl || '';
+      
+      // Get website analysis data from multiple sources
+      const localStorageAnalysis = localStorage.getItem('website_analysis_data');
+      const sessionStorageAnalysis = sessionStorage.getItem('website_analysis_data');
+      
+      let websiteAnalysisData = null;
+      if (localStorageAnalysis) {
+        try {
+          websiteAnalysisData = JSON.parse(localStorageAnalysis);
+        } catch (e) {
+          console.warn('Failed to parse localStorage website_analysis_data:', e);
+        }
+      }
+      if (!websiteAnalysisData && sessionStorageAnalysis) {
+        try {
+          websiteAnalysisData = JSON.parse(sessionStorageAnalysis);
+        } catch (e) {
+          console.warn('Failed to parse sessionStorage website_analysis_data:', e);
+        }
+      }
+      
+      console.log('CompetitorAnalysisStep: URL sources debug:', {
+        propUserUrl,
+        localStorageUrl,
+        sessionStorageUrl,
+        onboardingContextUrl,
+        finalUserUrl,
+        hasLocalStorageAnalysis: !!localStorageAnalysis,
+        hasSessionStorageAnalysis: !!sessionStorageAnalysis,
+        websiteAnalysisData: websiteAnalysisData ? 'present' : 'null'
+      });
 
       console.log('CompetitorAnalysisStep: Making request with data:', {
         user_url: finalUserUrl,
@@ -171,6 +202,11 @@ const CompetitorAnalysisStep: React.FC<CompetitorAnalysisStepProps> = ({
         website_analysis_data: websiteAnalysisData
       });
 
+      // Validate that we have a URL before making the request
+      if (!finalUserUrl || finalUserUrl.trim() === '') {
+        throw new Error('No website URL available for competitor analysis. Please complete Step 2 (Website Analysis) first.');
+      }
+
       const response = await aiApiClient.post('/api/onboarding/step3/discover-competitors', {
         // session_id removed - backend gets user from auth token
         user_url: finalUserUrl,
diff --git a/frontend/src/components/OnboardingWizard/Wizard.tsx b/frontend/src/components/OnboardingWizard/Wizard.tsx
index a38af266..9c2eb7e5 100644
--- a/frontend/src/components/OnboardingWizard/Wizard.tsx
+++ b/frontend/src/components/OnboardingWizard/Wizard.tsx
@@ -563,7 +563,7 @@ const Wizard: React.FC<WizardProps> = ({ onComplete }) => {
         key="research" 
         onContinue={handleNext} 
         onBack={handleBack}
-        userUrl={stepData?.website || ''}
+        userUrl={stepData?.website || localStorage.getItem('website_url') || ''}
         industryContext={stepData?.industryContext}
         onDataReady={handleCompetitorDataReady}
       />,