Add strict Stripe checkout guard via env flag

backend/app.py

@@ -48,8 +48,6 @@ load_dotenv(backend_dir / '.env')  # backend/.env
 load_dotenv(project_root / '.env')  # root .env (fallback)
 load_dotenv()  # CWD .env (fallback)
 
-PODCAST_ONLY_DEMO_MODE = os.getenv("PODCAST_ONLY_DEMO_MODE", "false").lower() in {"1", "true", "yes", "on"}
-
 # Set up clean logging for end users
 from logging_config import setup_clean_logging
 setup_clean_logging()
@@ -112,37 +110,36 @@ from services.startup_health import (
 # Import OAuth token monitoring routes
 from api.oauth_token_monitoring_routes import router as oauth_token_monitoring_router
 
-if not PODCAST_ONLY_DEMO_MODE:
-    # Import SEO Dashboard endpoints only when non-demo features are enabled
-    from api.seo_dashboard import (
-        get_seo_dashboard_data,
-        get_seo_health_score,
-        get_seo_metrics,
-        get_platform_status,
-        get_ai_insights,
-        seo_dashboard_health_check,
-        analyze_seo_comprehensive,
-        analyze_seo_full,
-        get_seo_metrics_detailed,
-        get_analysis_summary,
-        batch_analyze_urls,
-        SEOAnalysisRequest,
-        get_seo_dashboard_overview,
-        get_gsc_raw_data,
-        get_bing_raw_data,
-        get_competitive_insights,
-        get_deep_competitor_analysis,
-        run_strategic_insights,
-        get_strategic_insights_history,
-        refresh_analytics_data,
-        analyze_urls_ai,
-        AnalyzeURLsRequest,
-        get_analyzed_pages,
-        get_semantic_health,
-        get_semantic_cache_stats,
-        get_sif_indexing_health,
-        get_onboarding_task_health,
-    )
+# Import SEO Dashboard endpoints
+from api.seo_dashboard import (
+    get_seo_dashboard_data,
+    get_seo_health_score,
+    get_seo_metrics,
+    get_platform_status,
+    get_ai_insights,
+    seo_dashboard_health_check,
+    analyze_seo_comprehensive,
+    analyze_seo_full,
+    get_seo_metrics_detailed,
+    get_analysis_summary,
+    batch_analyze_urls,
+    SEOAnalysisRequest,
+    get_seo_dashboard_overview,
+    get_gsc_raw_data,
+    get_bing_raw_data,
+    get_competitive_insights,
+    get_deep_competitor_analysis,
+    run_strategic_insights,
+    get_strategic_insights_history,
+    refresh_analytics_data,
+    analyze_urls_ai,
+    AnalyzeURLsRequest,
+    get_analyzed_pages,
+    get_semantic_health,
+    get_semantic_cache_stats,
+    get_sif_indexing_health,
+    get_onboarding_task_health,
+)
 
 
 # Initialize FastAPI app
@@ -262,184 +259,194 @@ async def onboarding_status():
     return onboarding_manager.get_onboarding_status()
 
 # Include routers using modular utilities
-if not PODCAST_ONLY_DEMO_MODE:
-    router_manager.include_core_routers()
-    router_manager.include_optional_routers()
-else:
-    logger.info("PODCAST_ONLY_DEMO_MODE enabled: including only podcast and subscription feature routers.")
-    app.include_router(subscription_router)
+router_manager.include_core_routers()
+router_manager.include_optional_routers()
 
 # Include assets serving router (must be mounted to serve generated images)
 app.include_router(assets_serving_router)
 
-if not PODCAST_ONLY_DEMO_MODE:
-    # SEO Dashboard endpoints
-    @app.get("/api/seo-dashboard/data")
-    async def seo_dashboard_data():
-        """Get complete SEO dashboard data."""
-        return await get_seo_dashboard_data()
+# SEO Dashboard endpoints
+@app.get("/api/seo-dashboard/data")
+async def seo_dashboard_data():
+    """Get complete SEO dashboard data."""
+    return await get_seo_dashboard_data()
 
-    @app.get("/api/seo-dashboard/health-score")
-    async def seo_health_score():
-        """Get SEO health score."""
-        return await get_seo_health_score()
+@app.get("/api/seo-dashboard/health-score")
+async def seo_health_score():
+    """Get SEO health score."""
+    return await get_seo_health_score()
 
-    @app.get("/api/seo-dashboard/metrics")
-    async def seo_metrics():
-        """Get SEO metrics."""
-        return await get_seo_metrics()
+@app.get("/api/seo-dashboard/metrics")
+async def seo_metrics():
+    """Get SEO metrics."""
+    return await get_seo_metrics()
 
-    @app.get("/api/seo-dashboard/platforms")
-    async def seo_platforms(current_user: dict = Depends(get_current_user)):
-        """Get platform status."""
-        return await get_platform_status(current_user)
+@app.get("/api/seo-dashboard/platforms")
+async def seo_platforms(current_user: dict = Depends(get_current_user)):
+    """Get platform status."""
+    return await get_platform_status(current_user)
 
-    @app.get("/api/seo-dashboard/insights")
-    async def seo_insights():
-        """Get AI insights."""
-        return await get_ai_insights()
+@app.get("/api/seo-dashboard/insights")
+async def seo_insights():
+    """Get AI insights."""
+    return await get_ai_insights()
 
-    # New SEO Dashboard endpoints with real data
-    @app.get("/api/seo-dashboard/overview")
-    async def seo_dashboard_overview_endpoint(current_user: dict = Depends(get_current_user), site_url: str = None):
-        """Get comprehensive SEO dashboard overview with real GSC/Bing data."""
-        return await get_seo_dashboard_overview(current_user, site_url)
+# New SEO Dashboard endpoints with real data
+@app.get("/api/seo-dashboard/overview")
+async def seo_dashboard_overview_endpoint(current_user: dict = Depends(get_current_user), site_url: str = None):
+    """Get comprehensive SEO dashboard overview with real GSC/Bing data."""
+    return await get_seo_dashboard_overview(current_user, site_url)
 
-    @app.get("/api/seo-dashboard/gsc/raw")
-    async def gsc_raw_data_endpoint(current_user: dict = Depends(get_current_user), site_url: str = None):
-        """Get raw GSC data for the specified site."""
-        return await get_gsc_raw_data(current_user, site_url)
+@app.get("/api/seo-dashboard/gsc/raw")
+async def gsc_raw_data_endpoint(current_user: dict = Depends(get_current_user), site_url: str = None):
+    """Get raw GSC data for the specified site."""
+    return await get_gsc_raw_data(current_user, site_url)
 
-    @app.get("/api/seo-dashboard/bing/raw")
-    async def bing_raw_data_endpoint(current_user: dict = Depends(get_current_user), site_url: str = None):
-        """Get raw Bing data for the specified site."""
-        return await get_bing_raw_data(current_user, site_url)
+@app.get("/api/seo-dashboard/bing/raw")
+async def bing_raw_data_endpoint(current_user: dict = Depends(get_current_user), site_url: str = None):
+    """Get raw Bing data for the specified site."""
+    return await get_bing_raw_data(current_user, site_url)
 
-    @app.get("/api/seo-dashboard/competitive-insights")
-    async def competitive_insights_endpoint(current_user: dict = Depends(get_current_user), site_url: str = None):
-        """Get competitive insights from onboarding step 3 data."""
-        return await get_competitive_insights(current_user, site_url)
+@app.get("/api/seo-dashboard/competitive-insights")
+async def competitive_insights_endpoint(current_user: dict = Depends(get_current_user), site_url: str = None):
+    """Get competitive insights from onboarding step 3 data."""
+    return await get_competitive_insights(current_user, site_url)
 
-    @app.get("/api/seo-dashboard/deep-competitor-analysis")
-    async def deep_competitor_analysis_endpoint(current_user: dict = Depends(get_current_user), site_url: str = None):
-        """Get deep competitor analysis results (auto-scheduled post-onboarding)."""
-        return await get_deep_competitor_analysis(current_user, site_url)
+@app.get("/api/seo-dashboard/deep-competitor-analysis")
+async def deep_competitor_analysis_endpoint(current_user: dict = Depends(get_current_user), site_url: str = None):
+    """Get deep competitor analysis results (auto-scheduled post-onboarding)."""
+    return await get_deep_competitor_analysis(current_user, site_url)
 
-    @app.post("/api/seo-dashboard/strategic-insights/run")
-    async def run_strategic_insights_endpoint(current_user: dict = Depends(get_current_user)):
-        """Run AI-powered strategic insights analysis manually."""
-        return await run_strategic_insights(current_user)
+@app.post("/api/seo-dashboard/strategic-insights/run")
+async def run_strategic_insights_endpoint(current_user: dict = Depends(get_current_user)):
+    """Run AI-powered strategic insights analysis manually."""
+    return await run_strategic_insights(current_user)
 
-    @app.get("/api/seo-dashboard/strategic-insights/history")
-    async def get_strategic_insights_history_endpoint(current_user: dict = Depends(get_current_user)):
-        """Fetch the history of strategic insights for the user."""
-        return await get_strategic_insights_history(current_user)
+@app.get("/api/seo-dashboard/strategic-insights/history")
+async def get_strategic_insights_history_endpoint(current_user: dict = Depends(get_current_user)):
+    """Fetch the history of strategic insights for the user."""
+    return await get_strategic_insights_history(current_user)
 
-    @app.post("/api/seo-dashboard/refresh")
-    async def refresh_analytics_data_endpoint(current_user: dict = Depends(get_current_user), site_url: str = None):
-        """Refresh analytics data by invalidating cache and fetching fresh data."""
-        return await refresh_analytics_data(current_user, site_url)
+@app.post("/api/seo-dashboard/refresh")
+async def refresh_analytics_data_endpoint(current_user: dict = Depends(get_current_user), site_url: str = None):
+    """Refresh analytics data by invalidating cache and fetching fresh data."""
+    return await refresh_analytics_data(current_user, site_url)
 
-    @app.get("/api/seo-dashboard/onboarding-task-health")
-    async def onboarding_task_health_endpoint(current_user: dict = Depends(get_current_user), site_url: str = None):
-        """Get consolidated health for onboarding-scheduled SEO tasks."""
-        return await get_onboarding_task_health(current_user, site_url)
 
-    @app.get("/api/seo-dashboard/health")
-    async def seo_dashboard_health():
-        """Health check for SEO dashboard."""
-        return await seo_dashboard_health_check()
 
-    # Phase 2B: Semantic health monitoring endpoint (24-hour polling)
-    @app.get("/api/seo-dashboard/semantic-health")
-    async def semantic_health_endpoint(current_user: dict = Depends(get_current_user)):
-        """Get real-time semantic health metrics for content and competitors."""
-        return await get_semantic_health(current_user)
+@app.get("/api/seo-dashboard/onboarding-task-health")
+async def onboarding_task_health_endpoint(current_user: dict = Depends(get_current_user), site_url: str = None):
+    """Get consolidated health for onboarding-scheduled SEO tasks."""
+    return await get_onboarding_task_health(current_user, site_url)
 
-    @app.get("/api/seo-dashboard/cache-stats")
-    async def semantic_cache_stats_endpoint(current_user: dict = Depends(get_current_user)):
-        """Get semantic cache performance statistics."""
-        return await get_semantic_cache_stats(current_user)
+@app.get("/api/seo-dashboard/health")
+async def seo_dashboard_health():
+    """Health check for SEO dashboard."""
+    return await seo_dashboard_health_check()
 
-    @app.get("/api/seo-dashboard/sif-health")
-    async def sif_indexing_health_endpoint(current_user: dict = Depends(get_current_user)):
-        """Get SIF indexing health summary for the current user."""
-        return await get_sif_indexing_health(current_user)
+# Phase 2B: Semantic health monitoring endpoint (24-hour polling)
+@app.get("/api/seo-dashboard/semantic-health")
+async def semantic_health_endpoint(current_user: dict = Depends(get_current_user)):
+    """
+    Get real-time semantic health metrics for content and competitors.
+    This endpoint provides Phase 2B semantic intelligence monitoring data.
     
-    # Comprehensive SEO Analysis endpoints
-    @app.post("/api/seo-dashboard/analyze-comprehensive")
-    async def analyze_seo_comprehensive_endpoint(request: SEOAnalysisRequest):
-        """Analyze a URL for comprehensive SEO performance."""
-        return await analyze_seo_comprehensive(request)
+    Returns semantic health score, status, and recommendations.
+    Data is cached and updated every 24 hours via scheduler.
+    """
+    return await get_semantic_health(current_user)
 
-    @app.post("/api/seo-dashboard/analyze-full")
-    async def analyze_seo_full_endpoint(request: SEOAnalysisRequest):
-        """Analyze a URL for comprehensive SEO performance."""
-        return await analyze_seo_full(request)
 
-    @app.get("/api/seo-dashboard/metrics-detailed")
-    async def seo_metrics_detailed(url: str):
-        """Get detailed SEO metrics for a URL."""
-        return await get_seo_metrics_detailed(url)
+@app.get("/api/seo-dashboard/cache-stats")
+async def semantic_cache_stats_endpoint(current_user: dict = Depends(get_current_user)):
+    """
+    Get semantic cache performance statistics.
+    Returns hit rate, memory usage, and eviction counts.
+    """
+    return await get_semantic_cache_stats(current_user)
 
-    @app.get("/api/seo-dashboard/analysis-summary")
-    async def seo_analysis_summary(url: str):
-        """Get a quick summary of SEO analysis for a URL."""
-        return await get_analysis_summary(url)
 
-    @app.post("/api/seo-dashboard/batch-analyze")
-    async def batch_analyze_urls_endpoint(urls: list[str]):
-        """Analyze multiple URLs in batch."""
-        return await batch_analyze_urls(urls)
+@app.get("/api/seo-dashboard/sif-health")
+async def sif_indexing_health_endpoint(current_user: dict = Depends(get_current_user)):
+    """
+    Get SIF indexing health summary for the current user.
+    Used by the Semantic Indexing Status widget on the dashboard.
+    """
+    return await get_sif_indexing_health(current_user)
 
-    @app.post("/api/seo-dashboard/analyze-urls-ai")
-    async def analyze_urls_ai_endpoint(request: AnalyzeURLsRequest, current_user: dict = Depends(get_current_user)):
-        """Run AI-powered SEO analysis on selected URLs."""
-        return await analyze_urls_ai(request, current_user)
+# Comprehensive SEO Analysis endpoints
+@app.post("/api/seo-dashboard/analyze-comprehensive")
+async def analyze_seo_comprehensive_endpoint(request: SEOAnalysisRequest):
+    """Analyze a URL for comprehensive SEO performance."""
+    return await analyze_seo_comprehensive(request)
 
-    # Include platform analytics router
-    from routers.platform_analytics import router as platform_analytics_router
-    app.include_router(platform_analytics_router)
-    # Include Bing Analytics Storage router to expose storage-backed endpoints
-    from routers.bing_analytics_storage import router as bing_analytics_storage_router
-    app.include_router(bing_analytics_storage_router)
-    app.include_router(images_router)
-    app.include_router(image_studio_router)
-    app.include_router(product_marketing_router)
-    app.include_router(campaign_creator_router)
+@app.post("/api/seo-dashboard/analyze-full")
+async def analyze_seo_full_endpoint(request: SEOAnalysisRequest):
+    """Analyze a URL for comprehensive SEO performance."""
+    return await analyze_seo_full(request)
 
-    # Include content assets router
-    from api.content_assets.router import router as content_assets_router
-    app.include_router(content_assets_router)
+@app.get("/api/seo-dashboard/metrics-detailed")
+async def seo_metrics_detailed(url: str):
+    """Get detailed SEO metrics for a URL."""
+    return await get_seo_metrics_detailed(url)
+
+@app.get("/api/seo-dashboard/analysis-summary")
+async def seo_analysis_summary(url: str):
+    """Get a quick summary of SEO analysis for a URL."""
+    return await get_analysis_summary(url)
+
+@app.post("/api/seo-dashboard/batch-analyze")
+async def batch_analyze_urls_endpoint(urls: list[str]):
+    """Analyze multiple URLs in batch."""
+    return await batch_analyze_urls(urls)
+
+@app.post("/api/seo-dashboard/analyze-urls-ai")
+async def analyze_urls_ai_endpoint(request: AnalyzeURLsRequest, current_user: dict = Depends(get_current_user)):
+    """Run AI-powered SEO analysis on selected URLs."""
+    return await analyze_urls_ai(request, current_user)
+
+# Include platform analytics router
+from routers.platform_analytics import router as platform_analytics_router
+app.include_router(platform_analytics_router)
+# Include Bing Analytics Storage router to expose storage-backed endpoints
+from routers.bing_analytics_storage import router as bing_analytics_storage_router
+app.include_router(bing_analytics_storage_router)
+app.include_router(images_router)
+app.include_router(image_studio_router)
+app.include_router(product_marketing_router)
+app.include_router(campaign_creator_router)
+
+# Include content assets router
+from api.content_assets.router import router as content_assets_router
+app.include_router(content_assets_router)
 
 # Include Podcast Maker router
 from api.podcast.router import router as podcast_router
 app.include_router(podcast_router)
 
-if not PODCAST_ONLY_DEMO_MODE:
-    # Include YouTube Creator Studio router
-    from api.youtube.router import router as youtube_router
-    app.include_router(youtube_router, prefix="/api")
+# Include YouTube Creator Studio router
+from api.youtube.router import router as youtube_router
+app.include_router(youtube_router, prefix="/api")
 
-    # Include research configuration router
-    app.include_router(research_config_router, prefix="/api/research", tags=["research"])
+# Include research configuration router
+app.include_router(research_config_router, prefix="/api/research", tags=["research"])
 
-    # Include Research Engine router (standalone AI research module)
-    from api.research.router import router as research_engine_router
-    app.include_router(research_engine_router, tags=["Research Engine"])
+# Include Research Engine router (standalone AI research module)
+from api.research.router import router as research_engine_router
+app.include_router(research_engine_router, tags=["Research Engine"])
 
-    # Scheduler dashboard routes
-    from api.scheduler_dashboard import router as scheduler_dashboard_router
-    app.include_router(scheduler_dashboard_router)
-    app.include_router(oauth_token_monitoring_router)
+# Scheduler dashboard routes
+from api.scheduler_dashboard import router as scheduler_dashboard_router
+app.include_router(scheduler_dashboard_router)
+app.include_router(oauth_token_monitoring_router)
 
-    # Autonomous Agents API routes (Phase 3A)
-    from api.agents_api import router as agents_router
-    app.include_router(agents_router)
+# Autonomous Agents API routes (Phase 3A)
+from api.agents_api import router as agents_router
+app.include_router(agents_router)
 
-    # Today workflow routes
-    from api.today_workflow import router as today_workflow_router
-    app.include_router(today_workflow_router)
+# Today workflow routes
+from api.today_workflow import router as today_workflow_router
+app.include_router(today_workflow_router)
 
 # Setup frontend serving using modular utilities
 frontend_serving.setup_frontend_serving()

backend/services/subscription/stripe_service.py

@@ -16,6 +16,10 @@ REQUIRED_STRIPE_PLAN_KEYS = {
 }
 
 
+def _is_truthy_env(var_name: str) -> bool:
+    return os.getenv(var_name, "").strip().lower() in {"1", "true", "yes", "on"}
+
+
 def _detect_stripe_mode() -> str:
     configured_mode = os.getenv("STRIPE_MODE", "").strip().lower()
     if configured_mode in {"test", "live"}:
@@ -98,7 +102,16 @@ class StripeService:
         self.db = db
         self.api_key = os.getenv("STRIPE_SECRET_KEY")
         self.webhook_secret = os.getenv("STRIPE_WEBHOOK_SECRET")
+        self.require_stripe_checkout = _is_truthy_env("REQUIRE_STRIPE_CHECKOUT")
         if not self.api_key:
+            if self.require_stripe_checkout:
+                raise HTTPException(
+                    status_code=500,
+                    detail=(
+                        "REQUIRE_STRIPE_CHECKOUT=true but STRIPE_SECRET_KEY is missing. "
+                        "Configure STRIPE_SECRET_KEY to enable Stripe checkout."
+                    ),
+                )
             logger.warning("STRIPE_SECRET_KEY is not set. Stripe integration will not work.")
         else:
             stripe.api_key = self.api_key

frontend/src/components/Pricing/PricingPage.tsx

@@ -52,6 +52,10 @@ export interface SubscriptionPlan {
 }
 
 const PricingPage: React.FC = () => {
+  const requireStripeCheckout = ['1', 'true', 'yes', 'on'].includes(
+    (process.env.REACT_APP_REQUIRE_STRIPE_CHECKOUT || '').toLowerCase()
+  );
+  const stripePublishableKey = process.env.REACT_APP_STRIPE_PUBLISHABLE_KEY;
   const navigate = useNavigate();
   const [plans, setPlans] = useState<SubscriptionPlan[]>([]);
   const [loading, setLoading] = useState(true);
@@ -173,7 +177,7 @@ const PricingPage: React.FC = () => {
       const userId = localStorage.getItem('user_id') || 'anonymous';
 
       // Check if Stripe is configured
-      if (process.env.REACT_APP_STRIPE_PUBLISHABLE_KEY) {
+      if (stripePublishableKey) {
         console.log('[PricingPage] Initiating Stripe Checkout');
 
         const response = await apiClient.post('/api/subscription/create-checkout-session', {
@@ -187,6 +191,14 @@ const PricingPage: React.FC = () => {
           window.location.href = response.data.url;
           return;
         }
+
+        if (requireStripeCheckout) {
+          throw new Error('Stripe checkout is required but checkout URL was not returned.');
+        }
+      } else if (requireStripeCheckout) {
+        throw new Error(
+          'Stripe checkout is required but REACT_APP_STRIPE_PUBLISHABLE_KEY is not configured.'
+        );
       }
 
       console.log('[PricingPage] Making legacy subscription API call:', {
@@ -271,7 +283,8 @@ const PricingPage: React.FC = () => {
       }, 3000);
     } catch (err) {
       console.error('Error subscribing:', err);
-      setError('Failed to process subscription');
+      const errorMessage = err instanceof Error ? err.message : 'Failed to process subscription';
+      setError(errorMessage);
       setSuccessSnackbar({ open: false, message: '', countdown: 0 });
     } finally {
       setSubscribing(false);