Files
moreminimore-chat/spec/enterprise/models/contact_company_association_spec.rb
Sivin Varghese 56275b750e fix: respect companies feature flag for auto-association (#14886)
# Pull Request Template

## Description

This PR stops new contacts from getting an auto-assigned company name
when the Companies feature is disabled.

Since #14496, email-domain company auto-association also updates a
contact's `company_name`. However, the callback isn't gated behind the
Companies feature flag, so accounts without the feature enabled still
auto-create companies and overwrite any `company_name` provided via the
SDK/`setUser`.

This PR gates `should_associate_company?` behind
`account.feature_enabled?('companies')`, so auto-association only runs
when the Companies feature is enabled.

Fixes
https://linear.app/chatwoot/issue/CW-7462/setuser-overwrites-contact-company-name-for-accounts-that-dont-use

## Type of change

- [x] Bug fix (non-breaking change which fixes an issue)


## Checklist:

- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my code
- [x] I have commented on my code, particularly in hard-to-understand
areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [x] I have added tests that prove my fix is effective or that my
feature works
- [x] New and existing unit tests pass locally with my changes
- [ ] Any dependent changes have been merged and published in downstream
modules
2026-06-29 17:23:31 -07:00

107 lines
3.8 KiB
Ruby

require 'rails_helper'
RSpec.describe Contact, type: :model do
describe 'company auto-association' do
let(:account) { create(:account) }
before { account.enable_features!(:companies) }
context 'when the companies feature is disabled' do
before { account.disable_features!(:companies) }
it 'does not create or associate a company' do
expect do
create(:contact, email: 'john@acme.com', account: account)
end.not_to change(Company, :count)
expect(described_class.last.company).to be_nil
end
it 'preserves a contact-supplied company_name' do
contact = create(:contact, email: 'john@acme.com', account: account,
additional_attributes: { 'company_name' => 'John Personal Co' })
expect(contact.reload.additional_attributes['company_name']).to eq('John Personal Co')
end
end
context 'when creating a new contact with business email' do
it 'automatically creates and associates a company' do
expect do
create(:contact, email: 'john@acme.com', account: account)
end.to change(Company, :count).by(1)
contact = described_class.last
expect(contact.company).to be_present
expect(contact.company.domain).to eq('acme.com')
end
it 'does not create company for free email providers' do
expect do
create(:contact, email: 'john@gmail.com', account: account)
end.not_to change(Company, :count)
end
end
context 'when updating a contact to add email for first time' do
it 'creates and associates company' do
contact = create(:contact, email: nil, account: account)
expect do
contact.update(email: 'john@acme.com')
end.to change(Company, :count).by(1)
contact.reload
expect(contact.company.domain).to eq('acme.com')
end
end
context 'when updating a contact that already has a company' do
it 'does not change company when email changes' do
existing_company = create(:company, domain: 'oldcompany.com', account: account)
contact = create(:contact, email: 'john@oldcompany.com', company: existing_company, account: account)
expect do
contact.update(email: 'john@new_company.com')
end.not_to change(Company, :count)
contact.reload
expect(contact.company).to eq(existing_company)
end
it 'updates company activity when contact activity changes' do
company = create(:company, account: account)
contact = create(:contact, account: account, company: company)
contact.update!(last_activity_at: Time.zone.now)
expect(company.reload.last_activity_at).to be_within(1.second).of(contact.last_activity_at)
end
end
context 'when multiple contacts share the same domain' do
it 'associates all contacts with the same company' do
contacts = ['john@acme.com', 'jane@acme.com', 'bob@acme.com']
contacts.each do |contact|
create(:contact, email: contact, account: account)
end
expect(Company.where(domain: 'acme.com', account: account).count).to eq(1)
company = Company.find_by(domain: 'acme.com', account: account)
expect(company.contacts.count).to eq(contacts.length)
end
end
end
describe '#push_event_data' do
let(:account) { create(:account) }
let(:company) { create(:company, account: account) }
let(:contact) { create(:contact, account: account, company: company) }
it 'includes company_id when companies feature is enabled' do
account.enable_features!(:companies)
expect(contact.push_event_data[:company_id]).to eq(company.id)
end
it 'does not include company_id when companies feature is disabled' do
expect(contact.push_event_data).not_to have_key(:company_id)
end
end
end