ce8c8e9a11
Team names created via the API could contain control characters (for
example a trailing newline). Because the team-delete confirmation dialog
requires you to retype the team name and matches it against the stored
value, a hidden control character meant the typed name never matched —
leaving the team impossible to delete from the UI. This sanitizes team
names on save so they stay clean and deletable.
#### How to reproduce
1. Create a team via `POST /api/v1/accounts/{account_id}/teams` with
`{"name": "test\n"}`.
2. The team is created with the trailing newline stored in `name`.
3. In **Settings → Teams**, click delete and type the team name to
confirm — the match fails, so the team cannot be deleted.
#### What changed
- `app/models/team.rb`: the existing `before_validation` now strips
control characters and surrounding whitespace before downcasing the
name. Names that reduce to blank (e.g. only newlines/tabs) are rejected
loudly by the existing `presence` validation.
- Fixing at the model layer covers the API and every other create/update
path, rather than relying on the frontend confirm-dialog `.trim()`
(which only handles leading/trailing whitespace, not internal control
characters).
Note: this prevents new malformed names. Any team already saved with a
control character can be made deletable again simply by renaming it (an
update re-runs the same sanitization).
| Input | Stored as | Result |
|---|---|---|
| `"test\n"` | `"test"` | valid, deletable |
| `"te\nst"` (internal) | `"test"` | valid |
| `"\t\n "` (only control/ws) | — | rejected: "Name must not be blank" |
| `"Customer Support"` | `"customer support"` | unchanged behavior |
🤖 Generated with [Claude Code](https://claude.com/claude-code)
---------
Co-authored-by: Muhsin <12408980+muhsin-k@users.noreply.github.com>
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
75 lines
2.1 KiB
Ruby
75 lines
2.1 KiB
Ruby
# == Schema Information
|
|
#
|
|
# Table name: teams
|
|
#
|
|
# id :bigint not null, primary key
|
|
# allow_auto_assign :boolean default(TRUE)
|
|
# description :text
|
|
# icon :string default("")
|
|
# icon_color :string default("")
|
|
# name :string not null
|
|
# created_at :datetime not null
|
|
# updated_at :datetime not null
|
|
# account_id :bigint not null
|
|
#
|
|
# Indexes
|
|
#
|
|
# index_teams_on_account_id (account_id)
|
|
# index_teams_on_name_and_account_id (name,account_id) UNIQUE
|
|
#
|
|
class Team < ApplicationRecord
|
|
include AccountCacheRevalidator
|
|
|
|
belongs_to :account
|
|
has_many :team_members, dependent: :destroy_async
|
|
has_many :members, through: :team_members, source: :user
|
|
has_many :conversations, dependent: :nullify
|
|
|
|
validates :name,
|
|
presence: { message: I18n.t('errors.validations.presence') },
|
|
uniqueness: { scope: :account_id }
|
|
|
|
before_validation do
|
|
self.name = name.gsub(/[[:cntrl:]]/, '').strip.downcase if attribute_present?('name')
|
|
end
|
|
|
|
# Adds multiple members to the team
|
|
# @param user_ids [Array<Integer>] Array of user IDs to add as members
|
|
# @return [Array<User>] Array of newly added members
|
|
def add_members(user_ids)
|
|
team_members_to_create = user_ids.map { |user_id| { user_id: user_id } }
|
|
created_members = team_members.create(team_members_to_create)
|
|
added_users = created_members.filter_map(&:user)
|
|
|
|
update_account_cache
|
|
added_users
|
|
end
|
|
|
|
# Removes multiple members from the team
|
|
# @param user_ids [Array<Integer>] Array of user IDs to remove
|
|
# @return [void]
|
|
def remove_members(user_ids)
|
|
team_members.where(user_id: user_ids).destroy_all
|
|
update_account_cache
|
|
end
|
|
|
|
def messages
|
|
account.messages.where(conversation_id: conversations.pluck(:id))
|
|
end
|
|
|
|
def reporting_events
|
|
account.reporting_events.where(conversation_id: conversations.pluck(:id))
|
|
end
|
|
|
|
def push_event_data
|
|
{
|
|
id: id,
|
|
name: name,
|
|
icon: icon,
|
|
icon_color: icon_color
|
|
}
|
|
end
|
|
end
|
|
|
|
Team.include_mod_with('Audit::Team')
|