kunthawat/moreminimore-redesign
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Activity

Merge pull request #7 from emdash-cms/fix/create-emdash-spinner

Browse Source 
fix(create-emdash): fix spinner hanging during dep install
This commit is contained in:
Matt Kane
2026-04-01 14:24:28 +01:00
committed by GitHub
parent 025a8973e6 2022b77341
commit 0c6c66fe44
2 changed files with 10 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
.changeset/fix-create-emdash-spinner.md Normal file
View File

@@ -0,0 +1,5 @@
---
"create-emdash": patch
---
Fix spinner hanging during dependency installation by using async exec instead of execSync, which was blocking the event loop and preventing the spinner animation from updating.

10
packages/create-emdash/src/index.ts
View File

@@ -6,9 +6,12 @@
* Usage: npm create emdash@latest * Usage: npm create emdash@latest
*/ */
import { execSync } from "node:child_process"; import { exec } from "node:child_process";
import { existsSync, readFileSync, writeFileSync } from "node:fs"; import { existsSync, readFileSync, writeFileSync } from "node:fs";
import { resolve } from "node:path"; import { resolve } from "node:path";
import { promisify } from "node:util";
const execAsync = promisify(exec);
import * as p from "@clack/prompts"; import * as p from "@clack/prompts";
import { downloadTemplate } from "giget"; import { downloadTemplate } from "giget";
@@ -251,10 +254,7 @@ async function main() {
if (shouldInstall) { if (shouldInstall) {
s.start(`Installing dependencies with ${pc.cyan(pm)}...`); s.start(`Installing dependencies with ${pc.cyan(pm)}...`);
try { try {
execSync(installCmd, { await execAsync(installCmd, { cwd: projectDir });
cwd: projectDir,
stdio: "ignore",
});
s.stop("Dependencies installed!"); s.stop("Dependencies installed!");
} catch { } catch {
s.stop("Failed to install dependencies"); s.stop("Failed to install dependencies");