kunthawat/moreminimore-redesign
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Activity

fix: redirect to setup wizard on fresh deployments when public page is first request

Browse Source 
On a fresh CF deployment, if the first request hits a public page, the
middleware fast-path skips runtime init. Template helpers like
getSiteSettings() then query an empty database and crash with
'no such table: options'.

Add a one-time setup probe in the middleware fast-path: check if the
migrations table exists, and redirect to the setup wizard if not.
The check is cached for the worker lifetime after first success.

Also includes release workflow update to use GitHub App token and
admin branding changeset.
This commit is contained in:
Matt Kane
2026-04-01 14:14:05 +01:00
parent 4925c6014f
commit 3c319ed641
3 changed files with 45 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

35
packages/core/src/astro/middleware.ts
View File

@@ -54,6 +54,16 @@ let runtimeInitializing = false;
/** Whether i18n config has been initialized from the virtual module */
let i18nInitialized = false;
/**
* Whether we've verified the database has been set up.
* On a fresh deployment the first request may hit a public page, bypassing
* runtime init. Without this check, template helpers like getSiteSettings()
* would query an empty database and crash. Once verified (or once the runtime
* has initialized via an admin/API request), this stays true for the worker's
* lifetime.
*/
let setupVerified = false;
/**
* Get EmDash configuration from virtual module
*/
@@ -190,6 +200,28 @@ export const onRequest = defineMiddleware(async (context, next) => {
if (!isEmDashRoute && !isPublicRuntimeRoute && !hasEditCookie && !hasPreviewToken) {
const sessionUser = await context.session?.get("user");
if (!sessionUser && !playgroundDb) {
// On a fresh deployment the database may be completely empty.
// Public pages call getSiteSettings() / getMenu() via getDb(), which
// bypasses runtime init and would crash with "no such table: options".
// Do a one-time lightweight probe using the same getDb() instance the
// page will use: if the migrations table doesn't exist, no migrations
// have ever run -- redirect to the setup wizard.
if (!setupVerified) {
try {
const { getDb } = await import("../loader.js");
const db = await getDb();
await db
.selectFrom("_emdash_migrations" as keyof Database)
.selectAll()
.limit(1)
.execute();
setupVerified = true;
} catch {
// Table doesn't exist -> fresh database, redirect to setup
return context.redirect("/_emdash/admin/setup");
}
}
const response = await next();
setBaselineSecurityHeaders(response);
return response;
@@ -210,6 +242,9 @@ export const onRequest = defineMiddleware(async (context, next) => {
// Get or create runtime
const runtime = await getRuntime(config);
// Runtime init runs migrations, so the DB is guaranteed set up
setupVerified = true;
// Get manifest (cached after first call)
const manifest = await runtime.getManifest();