From 2ca14345b67bcfdb4a241a9ad6f91822d62480d8 Mon Sep 17 00:00:00 2001
From: Mohamed Aziz Mejri <mjrmohamedaziz@gmail.com>
Date: Tue, 2 Dec 2025 08:14:41 +0100
Subject: [PATCH] Preventing invalid characters in app names (#1839)

closes #1823

<!-- This is an auto-generated description by cubic. -->
---
## Summary by cubic
Blocks invalid characters in app folder paths during rename and shows
cleaner error messages in App Details. Prevents OS rename failures and
removes confusing IPC prefixes from errors.

- **Bug Fixes**
- Validate new appPath on rename; reject < > : " | ? * / \ and control
characters when the path changes, with a clear error message.
- Replace alert() with showError() and strip the IPC wrapper text for
user-friendly errors.

<sup>Written for commit 14b3c0978c1da3b97ca6d33e67684c7ff872ab0a.
Summary will update automatically on new commits.</sup>

<!-- End of auto-generated description by cubic. -->
---
 src/ipc/handlers/app_handlers.ts | 14 ++++++++++++++
 src/pages/app-details.tsx        | 19 ++++++++-----------
 2 files changed, 22 insertions(+), 11 deletions(-)

diff --git a/src/ipc/handlers/app_handlers.ts b/src/ipc/handlers/app_handlers.ts
index 590b789..fa13563 100644
--- a/src/ipc/handlers/app_handlers.ts
+++ b/src/ipc/handlers/app_handlers.ts
@@ -1202,6 +1202,20 @@ export function registerAppHandlers() {
           throw new Error("App not found");
         }
 
+        const pathChanged = appPath !== app.path;
+
+        if (pathChanged) {
+          const invalidChars = /[<>:"|?*\/\\]/;
+          const hasInvalidChars =
+            invalidChars.test(appPath) || /[\x00-\x1f]/.test(appPath);
+
+          if (hasInvalidChars) {
+            throw new Error(
+              `App path "${appPath}" contains characters that are not allowed in folder names: < > : " | ? * / \\ or control characters. Please use a different path.`,
+            );
+          }
+        }
+
         // Check for conflicts with existing apps
         const nameConflict = await db.query.apps.findFirst({
           where: eq(apps.name, appName),
diff --git a/src/pages/app-details.tsx b/src/pages/app-details.tsx
index b6a3238..a2fffdf 100644
--- a/src/pages/app-details.tsx
+++ b/src/pages/app-details.tsx
@@ -128,11 +128,10 @@ export default function AppDetailsPage() {
       await refreshApps();
     } catch (error) {
       console.error("Failed to rename app:", error);
-      alert(
-        `Error renaming app: ${
-          error instanceof Error ? error.message : String(error)
-        }`,
-      );
+      const errorMessage = (
+        error instanceof Error ? error.message : String(error)
+      ).replace(/^Error invoking remote method 'rename-app': Error: /, "");
+      showError(errorMessage);
     } finally {
       setIsRenaming(false);
     }
@@ -143,7 +142,6 @@ export default function AppDetailsPage() {
 
     try {
       setIsRenamingFolder(true);
-
       await IpcClient.getInstance().renameApp({
         appId,
         appName: selectedApp.name, // Keep the app name the same
@@ -154,11 +152,10 @@ export default function AppDetailsPage() {
       await refreshApps();
     } catch (error) {
       console.error("Failed to rename folder:", error);
-      alert(
-        `Error renaming folder: ${
-          error instanceof Error ? error.message : String(error)
-        }`,
-      );
+      const errorMessage = (
+        error instanceof Error ? error.message : String(error)
+      ).replace(/^Error invoking remote method 'rename-app': Error: /, "");
+      showError(errorMessage);
     } finally {
       setIsRenamingFolder(false);
     }