Refactor useVersions to @tanstack/react-query (#114)

working

src/components/chat/VersionPane.tsx

@@ -21,17 +21,20 @@ export function VersionPane({ isVisible, onClose }: VersionPaneProps) {
     selectedVersionIdAtom,
   );
   useEffect(() => {
-    // Refresh versions in case the user updated versions outside of the app
-    // (e.g. manually using git).
-    // Avoid loading state which causes brief flash of loading state.
-    refreshVersions();
-    if (!isVisible && selectedVersionId) {
-      setSelectedVersionId(null);
-      IpcClient.getInstance().checkoutVersion({
-        appId: appId!,
-        versionId: "main",
-      });
+    async function updateVersions() {
+      // Refresh versions in case the user updated versions outside of the app
+      // (e.g. manually using git).
+      // Avoid loading state which causes brief flash of loading state.
+      if (!isVisible && selectedVersionId) {
+        setSelectedVersionId(null);
+        await IpcClient.getInstance().checkoutVersion({
+          appId: appId!,
+          versionId: "main",
+        });
+      }
+      refreshVersions();
     }
+    updateVersions();
   }, [isVisible, refreshVersions]);
   if (!isVisible) {
     return null;

src/hooks/useVersions.ts

@@ -1,78 +1,79 @@
-import { useState, useEffect, useCallback } from "react";
+import { useCallback, useEffect } from "react";
 import { useAtom, useAtomValue } from "jotai";
 import { versionsListAtom } from "@/atoms/appAtoms";
 import { IpcClient } from "@/ipc/ipc_client";
 import { showError } from "@/lib/toast";
 import { chatMessagesAtom, selectedChatIdAtom } from "@/atoms/chatAtoms";
+import { useQuery, useMutation, useQueryClient } from "@tanstack/react-query";
+import type { Version } from "@/ipc/ipc_types";
 
 export function useVersions(appId: number | null) {
-  const [versions, setVersions] = useAtom(versionsListAtom);
-  const [loading, setLoading] = useState(true);
-  const [error, setError] = useState<Error | null>(null);
+  const [, setVersionsAtom] = useAtom(versionsListAtom);
   const selectedChatId = useAtomValue(selectedChatIdAtom);
   const [, setMessages] = useAtom(chatMessagesAtom);
-  useEffect(() => {
-    const loadVersions = async () => {
-      // If no app is selected, clear versions and return
+  const queryClient = useQueryClient();
+
+  const {
+    data: versions,
+    isLoading: loading,
+    error,
+    refetch: refreshVersions,
+  } = useQuery<Version[], Error>({
+    queryKey: ["versions", appId],
+    queryFn: async (): Promise<Version[]> => {
       if (appId === null) {
-        setVersions([]);
-        setLoading(false);
-        return;
+        return [];
       }
-
-      try {
-        const ipcClient = IpcClient.getInstance();
-        const versionsList = await ipcClient.listVersions({ appId });
-
-        setVersions(versionsList);
-        setError(null);
-      } catch (error) {
-        console.error("Error loading versions:", error);
-        setError(error instanceof Error ? error : new Error(String(error)));
-      } finally {
-        setLoading(false);
-      }
-    };
-
-    loadVersions();
-  }, [appId, setVersions]);
-
-  const refreshVersions = useCallback(async () => {
-    if (appId === null) {
-      return;
-    }
-
-    try {
       const ipcClient = IpcClient.getInstance();
-      const versionsList = await ipcClient.listVersions({ appId });
-      setVersions(versionsList);
-      setError(null);
-    } catch (error) {
-      console.error("Error refreshing versions:", error);
-      setError(error instanceof Error ? error : new Error(String(error)));
+      return ipcClient.listVersions({ appId });
+    },
+    enabled: appId !== null,
+    initialData: [],
+  });
+
+  useEffect(() => {
+    if (versions) {
+      setVersionsAtom(versions);
     }
-  }, [appId, setVersions, setError]);
+  }, [versions, setVersionsAtom]);
+
+  const revertVersionMutation = useMutation<void, Error, { versionId: string }>(
+    {
+      mutationFn: async ({ versionId }: { versionId: string }) => {
+        if (appId === null) {
+          throw new Error("App ID is null");
+        }
+        const ipcClient = IpcClient.getInstance();
+        await ipcClient.revertVersion({ appId, previousVersionId: versionId });
+      },
+      onSuccess: async () => {
+        await queryClient.invalidateQueries({ queryKey: ["versions", appId] });
+        if (selectedChatId) {
+          const chat = await IpcClient.getInstance().getChat(selectedChatId);
+          setMessages(chat.messages);
+        }
+      },
+      onError: (e: Error) => {
+        showError(e);
+      },
+    },
+  );
 
   const revertVersion = useCallback(
     async ({ versionId }: { versionId: string }) => {
       if (appId === null) {
         return;
       }
-
-      try {
-        const ipcClient = IpcClient.getInstance();
-        await ipcClient.revertVersion({ appId, previousVersionId: versionId });
-        await refreshVersions();
-        if (selectedChatId) {
-          const chat = await IpcClient.getInstance().getChat(selectedChatId);
-          setMessages(chat.messages);
-        }
-      } catch (error) {
-        showError(error);
-      }
+      await revertVersionMutation.mutateAsync({ versionId });
     },
-    [appId, setVersions, setError, selectedChatId, setMessages],
+    [appId, revertVersionMutation],
   );
 
-  return { versions, loading, error, refreshVersions, revertVersion };
+  return {
+    versions: versions || [],
+    loading,
+    error,
+    refreshVersions,
+    revertVersion,
+  };
 }

src/renderer.tsx

@@ -5,10 +5,13 @@ import { RouterProvider } from "@tanstack/react-router";
 import { PostHogProvider } from "posthog-js/react";
 import posthog from "posthog-js";
 import { getTelemetryUserId, isTelemetryOptedIn } from "./hooks/useSettings";
+import { QueryClient, QueryClientProvider } from "@tanstack/react-query";
 
 // @ts-ignore
 console.log("Running in mode:", import.meta.env.MODE);
 
+const queryClient = new QueryClient();
+
 const posthogClient = posthog.init(
   "phc_5Vxx0XT8Ug3eWROhP6mm4D6D2DgIIKT232q4AKxC2ab",
   {
@@ -71,8 +74,10 @@ function App() {
 
 createRoot(document.getElementById("root")!).render(
   <StrictMode>
-    <PostHogProvider client={posthogClient}>
-      <App />
-    </PostHogProvider>
+    <QueryClientProvider client={queryClient}>
+      <PostHogProvider client={posthogClient}>
+        <App />
+      </PostHogProvider>
+    </QueryClientProvider>
   </StrictMode>,
 );