Warn (not error) on identical search-replace blocks and include searc… (#1899)
…h-replace failure in error message Addresses part of #1898 <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Treat identical SEARCH/REPLACE as a no-op warning and propagate detailed applySearchReplace errors (incl. fuzzy match stats) to the UI; add scoped logging and update tests/snapshots. > > - **Processors**: > - `src/pro/main/ipc/processors/search_replace_processor.ts`: Log a warning (not error) when SEARCH and REPLACE blocks are identical; add scoped logger; keep content unchanged. > - `src/ipc/processors/response_processor.ts`: Include detailed failure reason from `applySearchReplace` in dry-run issues. > - **Tests & Snapshots**: > - `search_replace_processor.spec.ts`: Update test to expect success when blocks are identical. > - `e2e-tests/...turbo-edits-v2...snapshot`: Reflect detailed error message with fuzzy match similarity/threshold. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit a394d297d5561ada3bdd197dbb4e6aca6928ad99. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY --> <!-- This is an auto-generated description by cubic. --> --- ## Summary by cubic Warn instead of error when search and replace blocks are identical, and include the specific failure reason in search-replace error messages for clearer feedback. - **Bug Fixes** - Treat identical search/replace blocks as a no-op: log a warning and return success. - Bubble up detailed failure reasons to the UI (e.g., no match and fuzzy similarity/threshold). - Add scoped logging to the processor and update the e2e snapshot to reflect new error messaging. <sup>Written for commit a394d297d5561ada3bdd197dbb4e6aca6928ad99. Summary will update automatically on new commits.</sup> <!-- End of auto-generated description by cubic. -->
This commit is contained in:
@@ -18,7 +18,7 @@
|
||||
},
|
||||
{
|
||||
"role": "user",
|
||||
"content": "There was an issue with the following `dyad-search-replace` tags. Make sure you use `dyad-read` to read the latest version of the file and then trying to do search & replace again.\n \nFile path: src/pages/Index.tsx\nError: Unable to apply search-replace to file"
|
||||
"content": "There was an issue with the following `dyad-search-replace` tags. Make sure you use `dyad-read` to read the latest version of the file and then trying to do search & replace again.\n \nFile path: src/pages/Index.tsx\nError: Unable to apply search-replace to file because: Search block did not match any content in the target file. Best fuzzy match had similarity of 0.0% (threshold: 90.0%)"
|
||||
},
|
||||
{
|
||||
"role": "assistant",
|
||||
@@ -26,7 +26,7 @@
|
||||
},
|
||||
{
|
||||
"role": "user",
|
||||
"content": "There was an issue with the following `dyad-search-replace` tags. Please fix the errors by generating the code changes using `dyad-write` tags instead.\n \nFile path: src/pages/Index.tsx\nError: Unable to apply search-replace to file"
|
||||
"content": "There was an issue with the following `dyad-search-replace` tags. Please fix the errors by generating the code changes using `dyad-write` tags instead.\n \nFile path: src/pages/Index.tsx\nError: Unable to apply search-replace to file because: Search block did not match any content in the target file. Best fuzzy match had similarity of 0.0% (threshold: 90.0%)"
|
||||
}
|
||||
],
|
||||
"stream": true,
|
||||
|
||||
Reference in New Issue
Block a user