From 647fd0169e9b07e32fc4585704f3cbad42277602 Mon Sep 17 00:00:00 2001
From: Will Chen <willchen90@gmail.com>
Date: Thu, 29 May 2025 00:03:51 -0700
Subject: [PATCH] make it easy to write multiple e2e tests (#280)

---
 e2e-tests/fixtures/basic.md                   |  1 +
 e2e-tests/helpers/test_helper.ts              | 89 ++++++++++++++++++-
 e2e-tests/main.spec.ts                        | 51 +++--------
 ...ic-message-to-custom-test-model-1.aria.yml |  4 +
 playwright.config.ts                          |  2 +-
 src/app/TitleBar.tsx                          |  2 +
 src/lib/schemas.ts                            |  5 ++
 src/main.ts                                   |  5 ++
 src/pages/app-details.tsx                     |  5 +-
 src/pages/home.tsx                            |  4 +-
 src/paths/paths.ts                            |  3 +
 testing/fake-llm-server/index.ts              | 49 ++++++++--
 12 files changed, 169 insertions(+), 51 deletions(-)
 create mode 100644 e2e-tests/fixtures/basic.md
 create mode 100644 e2e-tests/snapshots/main.spec.ts_basic-message-to-custom-test-model-1.aria.yml

diff --git a/e2e-tests/fixtures/basic.md b/e2e-tests/fixtures/basic.md
new file mode 100644
index 0000000..668dfa6
--- /dev/null
+++ b/e2e-tests/fixtures/basic.md
@@ -0,0 +1 @@
+This is a simple basic response
diff --git a/e2e-tests/helpers/test_helper.ts b/e2e-tests/helpers/test_helper.ts
index a3618b9..f913db5 100644
--- a/e2e-tests/helpers/test_helper.ts
+++ b/e2e-tests/helpers/test_helper.ts
@@ -1,9 +1,86 @@
-import { test as base } from "@playwright/test";
+import { test as base, Page, expect } from "@playwright/test";
 import { findLatestBuild, parseElectronApp } from "electron-playwright-helpers";
 import { ElectronApplication, _electron as electron } from "playwright";
 
 const showDebugLogs = process.env.DEBUG_LOGS === "true";
 
+class PageObject {
+  constructor(private page: Page) {}
+
+  async setUp() {
+    await this.goToSettingsTab();
+    await this.setUpTestProvider();
+    await this.setUpTestModel();
+    await this.goToAppsTab();
+    await this.selectTestModel();
+  }
+
+  async dumpMessages() {
+    await expect(this.page.getByTestId("messages-list")).toMatchAriaSnapshot();
+  }
+
+  async waitForChatCompletion() {
+    await expect(
+      this.page.getByRole("button", { name: "Retry" }),
+    ).toBeVisible();
+  }
+
+  async sendPrompt(prompt: string) {
+    await this.page
+      .getByRole("textbox", { name: "Ask Dyad to build..." })
+      .click();
+    await this.page
+      .getByRole("textbox", { name: "Ask Dyad to build..." })
+      .fill(prompt);
+    await this.page.getByRole("button", { name: "Start new chat" }).click();
+    await this.waitForChatCompletion();
+  }
+
+  async selectTestModel() {
+    await this.page.getByRole("button", { name: "Model: Auto" }).click();
+    await this.page.getByText("test-provider").click();
+    await this.page.getByText("test-model").click();
+  }
+
+  async setUpTestProvider() {
+    await this.page.getByText("Add custom providerConnect to").click();
+    // Fill out provider dialog
+    await this.page
+      .getByRole("textbox", { name: "Provider ID" })
+      .fill("testing");
+    await this.page.getByRole("textbox", { name: "Display Name" }).click();
+    await this.page
+      .getByRole("textbox", { name: "Display Name" })
+      .fill("test-provider");
+    await this.page.getByText("API Base URLThe base URL for").click();
+    await this.page
+      .getByRole("textbox", { name: "API Base URL" })
+      .fill("http://localhost:3500/v1");
+    await this.page.getByRole("button", { name: "Add Provider" }).click();
+  }
+
+  async setUpTestModel() {
+    await this.page
+      .getByRole("heading", { name: "test-provider Needs Setup" })
+      .click();
+    await this.page.getByRole("button", { name: "Add Custom Model" }).click();
+    await this.page
+      .getByRole("textbox", { name: "Model ID*" })
+      .fill("test-model");
+    await this.page.getByRole("textbox", { name: "Model ID*" }).press("Tab");
+    await this.page.getByRole("textbox", { name: "Name*" }).fill("test-model");
+    await this.page.getByRole("button", { name: "Add Model" }).click();
+  }
+
+  async goToSettingsTab() {
+    await this.page.getByRole("link", { name: "Settings" }).click();
+  }
+
+  async goToAppsTab() {
+    await this.page.getByRole("link", { name: "Apps" }).click();
+  }
+}
+
 // From https://github.com/microsoft/playwright/issues/8208#issuecomment-1435475930
 //
 // Note how we mark the fixture as { auto: true }.
@@ -11,7 +88,17 @@ const showDebugLogs = process.env.DEBUG_LOGS === "true";
 export const test = base.extend<{
   attachScreenshotsToReport: void;
   electronApp: ElectronApplication;
+  po: PageObject;
 }>({
+  po: [
+    async ({ electronApp }, use) => {
+      const page = await electronApp.firstWindow();
+
+      const po = new PageObject(page);
+      await use(po);
+    },
+    { auto: true },
+  ],
   attachScreenshotsToReport: [
     async ({ page }, use, testInfo) => {
       await use();
diff --git a/e2e-tests/main.spec.ts b/e2e-tests/main.spec.ts
index 224abc2..148bb45 100644
--- a/e2e-tests/main.spec.ts
+++ b/e2e-tests/main.spec.ts
@@ -8,45 +8,14 @@ test("renders the first page", async ({ electronApp }) => {
   expect(text).toBe("Build your dream app");
 });
 
-test("simple message to custom test model", async ({ electronApp }) => {
-  const page = await electronApp.firstWindow();
-  await page.getByRole("link", { name: "Settings" }).click();
-  await page.getByText("Add custom providerConnect to").click();
-
-  // Fill out provider dialog
-  await page.getByRole("textbox", { name: "Provider ID" }).fill("testing");
-  await page.getByRole("textbox", { name: "Display Name" }).click();
-  await page
-    .getByRole("textbox", { name: "Display Name" })
-    .fill("test-provider");
-  await page.getByText("API Base URLThe base URL for").click();
-  await page
-    .getByRole("textbox", { name: "API Base URL" })
-    .fill("http://localhost:3500/v1");
-  await page.getByRole("button", { name: "Add Provider" }).click();
-
-  // Create custom model
-  await page
-    .getByRole("heading", { name: "test-provider Needs Setup" })
-    .click();
-  await page.getByRole("button", { name: "Add Custom Model" }).click();
-  await page.getByRole("textbox", { name: "Model ID*" }).fill("test-model");
-  await page.getByRole("textbox", { name: "Model ID*" }).press("Tab");
-  await page.getByRole("textbox", { name: "Name*" }).fill("test-model");
-  await page.getByRole("button", { name: "Add Model" }).click();
-
-  // Go to apps page and select custom model
-  await page.getByRole("link", { name: "Apps" }).click();
-  await page.getByRole("button", { name: "Model: Auto" }).click();
-  await page.getByText("test-provider").click();
-  await page.getByText("test-model").click();
-
-  // Enter prompt and send
-  await page.getByRole("textbox", { name: "Ask Dyad to build..." }).click();
-  await page.getByRole("textbox", { name: "Ask Dyad to build..." }).fill("hi");
-  await page.getByRole("button", { name: "Start new chat" }).click();
-
-  // Make sure it's done
-  await expect(page.getByRole("button", { name: "Retry" })).not.toBeVisible();
-  await expect(page.getByTestId("messages-list")).toMatchAriaSnapshot();
+test("simple message to custom test model", async ({ po }) => {
+  await po.setUp();
+  await po.sendPrompt("hi");
+  await po.dumpMessages();
+});
+
+test("basic message to custom test model", async ({ po }) => {
+  await po.setUp();
+  await po.sendPrompt("tc=basic");
+  await po.dumpMessages();
 });
diff --git a/e2e-tests/snapshots/main.spec.ts_basic-message-to-custom-test-model-1.aria.yml b/e2e-tests/snapshots/main.spec.ts_basic-message-to-custom-test-model-1.aria.yml
new file mode 100644
index 0000000..ff9ddd9
--- /dev/null
+++ b/e2e-tests/snapshots/main.spec.ts_basic-message-to-custom-test-model-1.aria.yml
@@ -0,0 +1,4 @@
+- paragraph: tc=basic
+- paragraph: This is a simple basic response
+- button "Retry":
+  - img
\ No newline at end of file
diff --git a/playwright.config.ts b/playwright.config.ts
index 2bbf85f..fe6d36c 100644
--- a/playwright.config.ts
+++ b/playwright.config.ts
@@ -3,7 +3,7 @@ import { PlaywrightTestConfig } from "@playwright/test";
 const config: PlaywrightTestConfig = {
   testDir: "./e2e-tests",
   maxFailures: 1,
-  timeout: process.env.CI ? 30_000 : 10_000,
+  timeout: process.env.CI ? 30_000 : 15_000,
   // Use a custom snapshot path template because Playwright's default
   // is platform-specific which isn't necessary for Dyad e2e tests
   // which should be platform agnostic (we don't do screenshots; only textual diffs).
diff --git a/src/app/TitleBar.tsx b/src/app/TitleBar.tsx
index 1cbfc39..38fffef 100644
--- a/src/app/TitleBar.tsx
+++ b/src/app/TitleBar.tsx
@@ -72,6 +72,7 @@ export const TitleBar = () => {
         <div className="pl-20"></div>
         <img src={logo} alt="Dyad Logo" className="w-6 h-6 mr-2" />
         <Button
+          data-testid="title-bar-app-name-button"
           variant="outline"
           size="sm"
           className={`hidden @md:block no-app-region-drag text-sm font-medium ${
@@ -83,6 +84,7 @@ export const TitleBar = () => {
         </Button>
         {isDyadPro && (
           <Button
+            data-testid="title-bar-dyad-pro-button"
             onClick={() => {
               navigate({
                 to: providerSettingsRoute.id,
diff --git a/src/lib/schemas.ts b/src/lib/schemas.ts
index 4d3aebc..d3ff133 100644
--- a/src/lib/schemas.ts
+++ b/src/lib/schemas.ts
@@ -122,6 +122,11 @@ export const UserSettingsSchema = z.object({
   enableProSmartFilesContextMode: z.boolean().optional(),
   selectedTemplateId: z.string().optional(),
 
+  ////////////////////////////////
+  // E2E TESTING ONLY.
+  ////////////////////////////////
+  isTestMode: z.boolean().optional(),
+
   ////////////////////////////////
   // DEPRECATED.
   ////////////////////////////////
diff --git a/src/main.ts b/src/main.ts
index bc576f1..2038c3c 100644
--- a/src/main.ts
+++ b/src/main.ts
@@ -58,6 +58,11 @@ export async function onFirstRunMaybe() {
       hasRunBefore: true,
     });
   }
+  if (process.env.E2E_TEST_BUILD) {
+    writeSettings({
+      isTestMode: true,
+    });
+  }
 }
 
 /**
diff --git a/src/pages/app-details.tsx b/src/pages/app-details.tsx
index 37288d9..bb6988a 100644
--- a/src/pages/app-details.tsx
+++ b/src/pages/app-details.tsx
@@ -161,7 +161,10 @@ export default function AppDetailsPage() {
   const fullAppPath = appBasePath.replace("$APP_BASE_PATH", selectedApp.path);
 
   return (
-    <div className="relative min-h-screen p-4 w-full">
+    <div
+      className="relative min-h-screen p-4 w-full"
+      data-testid="app-details-page"
+    >
       <Button
         onClick={() => router.history.back()}
         variant="outline"
diff --git a/src/pages/home.tsx b/src/pages/home.tsx
index 2641219..11f937b 100644
--- a/src/pages/home.tsx
+++ b/src/pages/home.tsx
@@ -124,7 +124,9 @@ export default function HomePage() {
         chatId: result.chatId,
         attachments,
       });
-      await new Promise((resolve) => setTimeout(resolve, 2000));
+      await new Promise((resolve) =>
+        setTimeout(resolve, settings?.isTestMode ? 0 : 2000),
+      );
 
       setInputValue("");
       setSelectedAppId(result.app.id);
diff --git a/src/paths/paths.ts b/src/paths/paths.ts
index 8e03883..2543066 100644
--- a/src/paths/paths.ts
+++ b/src/paths/paths.ts
@@ -2,6 +2,9 @@ import path from "node:path";
 import os from "node:os";
 
 export function getDyadAppPath(appPath: string): string {
+  if (process.env.E2E_TEST_BUILD) {
+    return path.join("/tmp", "dyad-apps-test", appPath);
+  }
   return path.join(os.homedir(), "dyad-apps", appPath);
 }
 
diff --git a/testing/fake-llm-server/index.ts b/testing/fake-llm-server/index.ts
index 82ccf7b..164f7f5 100644
--- a/testing/fake-llm-server/index.ts
+++ b/testing/fake-llm-server/index.ts
@@ -1,6 +1,8 @@
 import express from "express";
 import { createServer } from "http";
 import cors from "cors";
+import fs from "fs";
+import path from "path";
 
 // Create Express app
 const app = express();
@@ -72,6 +74,38 @@ app.post("/v1/chat/completions", (req, res) => {
     });
   }
 
+  // Check if the last message starts with "tc=" to load test case file
+  let messageContent = CANNED_MESSAGE;
+  if (
+    lastMessage &&
+    lastMessage.content &&
+    lastMessage.content.startsWith("tc=")
+  ) {
+    const testCaseName = lastMessage.content.slice(3); // Remove "tc=" prefix
+    const testFilePath = path.join(
+      __dirname,
+      "..",
+      "..",
+      "..",
+      "e2e-tests",
+      "fixtures",
+      `${testCaseName}.md`,
+    );
+
+    try {
+      if (fs.existsSync(testFilePath)) {
+        messageContent = fs.readFileSync(testFilePath, "utf-8");
+        console.log(`* Loaded test case: ${testCaseName}`);
+      } else {
+        console.log(`* Test case file not found: ${testFilePath}`);
+        messageContent = `Error: Test case file not found: ${testCaseName}.md`;
+      }
+    } catch (error) {
+      console.error(`* Error reading test case file: ${error}`);
+      messageContent = `Error: Could not read test case file: ${testCaseName}.md`;
+    }
+  }
+
   // Non-streaming response
   if (!stream) {
     return res.json({
@@ -84,7 +118,7 @@ app.post("/v1/chat/completions", (req, res) => {
           index: 0,
           message: {
             role: "assistant",
-            content: CANNED_MESSAGE,
+            content: messageContent,
           },
           finish_reason: "stop",
         },
@@ -97,27 +131,30 @@ app.post("/v1/chat/completions", (req, res) => {
   res.setHeader("Cache-Control", "no-cache");
   res.setHeader("Connection", "keep-alive");
 
-  // Split the "hello world" message into characters to simulate streaming
-  const message = CANNED_MESSAGE;
+  // Split the message into characters to simulate streaming
+  const message = messageContent;
   const messageChars = message.split("");
 
   // Stream each character with a delay
   let index = 0;
+  const batchSize = 8;
 
   // Send role first
   res.write(createStreamChunk("", "assistant"));
 
   const interval = setInterval(() => {
     if (index < messageChars.length) {
-      res.write(createStreamChunk(messageChars[index]));
-      index++;
+      // Get the next batch of characters (up to batchSize)
+      const batch = messageChars.slice(index, index + batchSize).join("");
+      res.write(createStreamChunk(batch));
+      index += batchSize;
     } else {
       // Send the final chunk
       res.write(createStreamChunk("", "assistant", true));
       clearInterval(interval);
       res.end();
     }
-  }, 10);
+  }, 1);
 });
 
 // Start the server