Problems: auto-fix & problem panel (#541)
Test cases: - [x] create-ts-errors - [x] with auto-fix - [x] without auto-fix - [x] create-unfixable-ts-errors - [x] manually edit file & click recheck - [x] fix all - [x] delete and rename case THINGS - [x] error handling for checkProblems isn't working as expected - [x] make sure it works for both default templates (add tests) - [x] fix bad animation - [x] change file context (prompt/files) IF everything passes in Windows AND defensive try catch... then enable by default - [x] enable auto-fix by default
This commit is contained in:
Will Chen
208
src/components/preview_panel/Problems.tsx
Normal file
208
src/components/preview_panel/Problems.tsx
Normal file
@@ -0,0 +1,208 @@
|
||||
import { useAtom, useAtomValue } from "jotai";
|
||||
import { selectedChatIdAtom } from "@/atoms/chatAtoms";
|
||||
import { selectedAppIdAtom } from "@/atoms/appAtoms";
|
||||
import {
|
||||
AlertTriangle,
|
||||
XCircle,
|
||||
FileText,
|
||||
Wrench,
|
||||
RefreshCw,
|
||||
} from "lucide-react";
|
||||
import { Problem, ProblemReport } from "@/ipc/ipc_types";
|
||||
import { Button } from "@/components/ui/button";
|
||||
|
||||
import { useStreamChat } from "@/hooks/useStreamChat";
|
||||
import { useCheckProblems } from "@/hooks/useCheckProblems";
|
||||
import { createProblemFixPrompt } from "@/shared/problem_prompt";
|
||||
import { showError } from "@/lib/toast";
|
||||
|
||||
interface ProblemItemProps {
|
||||
problem: Problem;
|
||||
}
|
||||
|
||||
const ProblemItem = ({ problem }: ProblemItemProps) => {
|
||||
return (
|
||||
<div className="flex items-start gap-3 p-3 border-b border-border hover:bg-[var(--background-darkest)] transition-colors">
|
||||
<div className="flex-shrink-0 mt-0.5">
|
||||
<XCircle size={16} className="text-red-500" />
|
||||
</div>
|
||||
<div className="flex-1 min-w-0">
|
||||
<div className="flex items-center gap-2 mb-1">
|
||||
<FileText size={14} className="text-muted-foreground flex-shrink-0" />
|
||||
<span className="text-sm font-medium truncate">{problem.file}</span>
|
||||
|
||||
<span className="text-xs text-muted-foreground">
|
||||
{problem.line}:{problem.column}
|
||||
</span>
|
||||
</div>
|
||||
<p className="text-sm text-foreground leading-relaxed">
|
||||
{problem.message}
|
||||
</p>
|
||||
</div>
|
||||
</div>
|
||||
);
|
||||
};
|
||||
|
||||
interface RecheckButtonProps {
|
||||
appId: number;
|
||||
size?: "sm" | "default" | "lg";
|
||||
variant?:
|
||||
| "default"
|
||||
| "destructive"
|
||||
| "outline"
|
||||
| "secondary"
|
||||
| "ghost"
|
||||
| "link";
|
||||
className?: string;
|
||||
}
|
||||
|
||||
const RecheckButton = ({
|
||||
appId,
|
||||
size = "sm",
|
||||
variant = "outline",
|
||||
className = "h-7 px-3 text-xs",
|
||||
}: RecheckButtonProps) => {
|
||||
const { checkProblems, isChecking } = useCheckProblems(appId);
|
||||
|
||||
const handleRecheck = async () => {
|
||||
const res = await checkProblems();
|
||||
if (res.error) {
|
||||
showError(res.error);
|
||||
}
|
||||
};
|
||||
|
||||
return (
|
||||
<Button
|
||||
size={size}
|
||||
variant={variant}
|
||||
onClick={handleRecheck}
|
||||
disabled={isChecking}
|
||||
className={className}
|
||||
data-testid="recheck-button"
|
||||
>
|
||||
<RefreshCw
|
||||
size={14}
|
||||
className={`mr-1 ${isChecking ? "animate-spin" : ""}`}
|
||||
/>
|
||||
{isChecking ? "Checking..." : "Recheck"}
|
||||
</Button>
|
||||
);
|
||||
};
|
||||
|
||||
interface ProblemsSummaryProps {
|
||||
problemReport: ProblemReport;
|
||||
appId: number;
|
||||
}
|
||||
|
||||
const ProblemsSummary = ({ problemReport, appId }: ProblemsSummaryProps) => {
|
||||
const { streamMessage } = useStreamChat();
|
||||
const { problems } = problemReport;
|
||||
const totalErrors = problems.length;
|
||||
const [selectedChatId] = useAtom(selectedChatIdAtom);
|
||||
const handleFixAll = () => {
|
||||
if (!selectedChatId) {
|
||||
return;
|
||||
}
|
||||
streamMessage({
|
||||
prompt: createProblemFixPrompt(problemReport),
|
||||
chatId: selectedChatId,
|
||||
});
|
||||
};
|
||||
|
||||
if (problems.length === 0) {
|
||||
return (
|
||||
<div className="flex flex-col items-center justify-center h-32 text-center">
|
||||
<div className="w-12 h-12 rounded-full bg-green-100 dark:bg-green-900/20 flex items-center justify-center mb-3">
|
||||
<div className="w-6 h-6 rounded-full bg-green-500"></div>
|
||||
</div>
|
||||
<p className="text-sm text-muted-foreground mb-3">No problems found</p>
|
||||
<RecheckButton appId={appId} />
|
||||
</div>
|
||||
);
|
||||
}
|
||||
|
||||
return (
|
||||
<div className="flex items-center justify-between px-4 py-3 bg-[var(--background-darkest)] border-b border-border">
|
||||
<div className="flex items-center gap-4">
|
||||
{totalErrors > 0 && (
|
||||
<div className="flex items-center gap-2">
|
||||
<XCircle size={16} className="text-red-500" />
|
||||
<span className="text-sm font-medium">
|
||||
{totalErrors} {totalErrors === 1 ? "error" : "errors"}
|
||||
</span>
|
||||
</div>
|
||||
)}
|
||||
</div>
|
||||
<div className="flex items-center gap-2">
|
||||
<RecheckButton appId={appId} />
|
||||
<Button
|
||||
size="sm"
|
||||
variant="default"
|
||||
onClick={handleFixAll}
|
||||
className="h-7 px-3 text-xs"
|
||||
data-testid="fix-all-button"
|
||||
>
|
||||
<Wrench size={14} className="mr-1" />
|
||||
Fix All
|
||||
</Button>
|
||||
</div>
|
||||
</div>
|
||||
);
|
||||
};
|
||||
|
||||
export function Problems() {
|
||||
return (
|
||||
<div data-testid="problems-pane">
|
||||
<_Problems />
|
||||
</div>
|
||||
);
|
||||
}
|
||||
|
||||
export function _Problems() {
|
||||
const selectedAppId = useAtomValue(selectedAppIdAtom);
|
||||
const { problemReport } = useCheckProblems(selectedAppId);
|
||||
|
||||
if (!selectedAppId) {
|
||||
return (
|
||||
<div className="flex flex-col items-center justify-center h-full text-center p-8">
|
||||
<div className="w-16 h-16 rounded-full bg-[var(--background-darkest)] flex items-center justify-center mb-4">
|
||||
<AlertTriangle size={24} className="text-muted-foreground" />
|
||||
</div>
|
||||
<h3 className="text-lg font-medium mb-2">No App Selected</h3>
|
||||
<p className="text-sm text-muted-foreground max-w-md">
|
||||
Select an app to view TypeScript problems and diagnostic information.
|
||||
</p>
|
||||
</div>
|
||||
);
|
||||
}
|
||||
|
||||
if (!problemReport) {
|
||||
return (
|
||||
<div className="flex flex-col items-center justify-center h-full text-center p-8">
|
||||
<div className="w-16 h-16 rounded-full bg-[var(--background-darkest)] flex items-center justify-center mb-4">
|
||||
<FileText size={24} className="text-muted-foreground" />
|
||||
</div>
|
||||
<h3 className="text-lg font-medium mb-2">No Problems Data</h3>
|
||||
<p className="text-sm text-muted-foreground max-w-md mb-4">
|
||||
No TypeScript diagnostics available for this app yet. Problems will
|
||||
appear here after running type checking.
|
||||
</p>
|
||||
<RecheckButton appId={selectedAppId} />
|
||||
</div>
|
||||
);
|
||||
}
|
||||
|
||||
return (
|
||||
<div className="flex flex-col h-full">
|
||||
<ProblemsSummary problemReport={problemReport} appId={selectedAppId} />
|
||||
<div className="flex-1 overflow-y-auto">
|
||||
{problemReport.problems.map((problem, index) => (
|
||||
<ProblemItem
|
||||
key={`${problem.file}-${problem.line}-${problem.column}-${index}`}
|
||||
problem={problem}
|
||||
/>
|
||||
))}
|
||||
</div>
|
||||
</div>
|
||||
);
|
||||
}
|
||||
Reference in New Issue
Block a user