From 7041525c20675c39a7eb2d41f156438707f8c7ba Mon Sep 17 00:00:00 2001
From: Will Chen <willchen90@gmail.com>
Date: Mon, 21 Apr 2025 16:19:40 -0700
Subject: [PATCH] Handle rename & deletes in proposal

---
 src/components/chat/ChatInput.tsx     | 25 ++++++++++---
 src/ipc/handlers/proposal_handlers.ts | 51 +++++++++++++++++++--------
 src/lib/schemas.ts                    |  1 +
 3 files changed, 59 insertions(+), 18 deletions(-)

diff --git a/src/components/chat/ChatInput.tsx b/src/components/chat/ChatInput.tsx
index ca7ef00..02339a5 100644
--- a/src/components/chat/ChatInput.tsx
+++ b/src/components/chat/ChatInput.tsx
@@ -10,6 +10,8 @@ import {
   Check,
   Loader2,
   Package,
+  FileX,
+  SendToBack,
 } from "lucide-react";
 import type React from "react";
 import { useCallback, useEffect, useRef, useState } from "react";
@@ -32,6 +34,7 @@ import {
   Proposal,
   SuggestedAction,
   ProposalResult,
+  FileChange,
 } from "@/lib/schemas";
 import type { Message } from "@/ipc/ipc_types";
 import { isPreviewOpenAtom } from "@/atoms/viewAtoms";
@@ -461,10 +464,7 @@ function ChatInputActions({
               <ul className="space-y-1">
                 {proposal.filesChanged.map((file, index) => (
                   <li key={index} className="flex items-center space-x-2">
-                    <FileText
-                      size={16}
-                      className="text-muted-foreground flex-shrink-0"
-                    />
+                    {getIconForFileChange(file)}
                     <span title={file.path} className="truncate cursor-default">
                       {file.name}
                     </span>
@@ -481,3 +481,20 @@ function ChatInputActions({
     </div>
   );
 }
+
+function getIconForFileChange(file: FileChange) {
+  switch (file.type) {
+    case "write":
+      return (
+        <FileText size={16} className="text-muted-foreground flex-shrink-0" />
+      );
+    case "rename":
+      return (
+        <SendToBack size={16} className="text-muted-foreground flex-shrink-0" />
+      );
+    case "delete":
+      return (
+        <FileX size={16} className="text-muted-foreground flex-shrink-0" />
+      );
+  }
+}
diff --git a/src/ipc/handlers/proposal_handlers.ts b/src/ipc/handlers/proposal_handlers.ts
index 6a8122b..aa0845a 100644
--- a/src/ipc/handlers/proposal_handlers.ts
+++ b/src/ipc/handlers/proposal_handlers.ts
@@ -1,5 +1,9 @@
 import { ipcMain, type IpcMainInvokeEvent } from "electron";
-import type { CodeProposal, ProposalResult } from "@/lib/schemas";
+import type {
+  CodeProposal,
+  FileChange,
+  ProposalResult,
+} from "../../lib/schemas";
 import { db } from "../../db";
 import { messages } from "../../db/schema";
 import { desc, eq, and, Update } from "drizzle-orm";
@@ -8,6 +12,8 @@ import path from "node:path"; // Import path for basename
 import {
   getDyadAddDependencyTags,
   getDyadChatSummaryTag,
+  getDyadDeleteTags,
+  getDyadRenameTags,
   getDyadWriteTags,
   processFullResponseActions,
 } from "../processors/response_processor";
@@ -65,34 +71,51 @@ const getProposalHandler = async (
       );
       const messageContent = latestAssistantMessage.content;
 
-      // Parse tags directly from message content
       const proposalTitle = getDyadChatSummaryTag(messageContent);
-      const proposalFiles = getDyadWriteTags(messageContent); // Gets { path: string, content: string }[]
+
+      const proposalWriteFiles = getDyadWriteTags(messageContent);
+      const proposalRenameFiles = getDyadRenameTags(messageContent);
+      const proposalDeleteFiles = getDyadDeleteTags(messageContent);
+
       const packagesAdded = getDyadAddDependencyTags(messageContent);
 
+      const filesChanged = [
+        ...proposalWriteFiles.map((tag) => ({
+          name: path.basename(tag.path),
+          path: tag.path,
+          summary: tag.description ?? "(no change summary found)", // Generic summary
+          type: "write" as const,
+        })),
+        ...proposalRenameFiles.map((tag) => ({
+          name: path.basename(tag.to),
+          path: tag.to,
+          summary: `Rename from ${tag.from} to ${tag.to}`,
+          type: "rename" as const,
+        })),
+        ...proposalDeleteFiles.map((tag) => ({
+          name: path.basename(tag),
+          path: tag,
+          summary: `Delete file`,
+          type: "delete" as const,
+        })),
+      ];
       // Check if we have enough information to create a proposal
-      if (
-        proposalTitle ||
-        proposalFiles.length > 0 ||
-        packagesAdded.length > 0
-      ) {
+      if (filesChanged.length > 0 || packagesAdded.length > 0) {
         const proposal: CodeProposal = {
           type: "code-proposal",
           // Use parsed title or a default title if summary tag is missing but write tags exist
           title: proposalTitle ?? "Proposed File Changes",
           securityRisks: [], // Keep empty
-          filesChanged: proposalFiles.map((tag) => ({
-            name: path.basename(tag.path),
-            path: tag.path,
-            summary: tag.description ?? "(no change summary found)", // Generic summary
-          })),
+          filesChanged,
           packagesAdded,
         };
         logger.log(
           "Generated code proposal. title=",
           proposal.title,
           "files=",
-          proposal.filesChanged.length
+          proposal.filesChanged.length,
+          "packages=",
+          proposal.packagesAdded.length
         );
         return { proposal, chatId, messageId }; // Return proposal and messageId
       } else {
diff --git a/src/lib/schemas.ts b/src/lib/schemas.ts
index 80ff894..08045b4 100644
--- a/src/lib/schemas.ts
+++ b/src/lib/schemas.ts
@@ -111,6 +111,7 @@ export interface FileChange {
   name: string;
   path: string;
   summary: string;
+  type: "write" | "rename" | "delete";
 }
 
 export interface CodeProposal {