From 87a0de438c7af73b7a6aaceb012215ed9c6efb3c Mon Sep 17 00:00:00 2001
From: Will Chen <willchen90@gmail.com>
Date: Tue, 24 Jun 2025 16:16:08 -0700
Subject: [PATCH] fix select component test (#485)

---
 e2e-tests/helpers/test_helper.ts   | 16 +++++++++++++++-
 e2e-tests/select_component.spec.ts |  4 +++-
 playwright.config.ts               |  2 +-
 3 files changed, 19 insertions(+), 3 deletions(-)

diff --git a/e2e-tests/helpers/test_helper.ts b/e2e-tests/helpers/test_helper.ts
index 2af8097..55719e7 100644
--- a/e2e-tests/helpers/test_helper.ts
+++ b/e2e-tests/helpers/test_helper.ts
@@ -649,8 +649,22 @@ export class PageObject {
     await this.page.getByRole("button", { name: "Open in Chat" }).click();
   }
 
+  locateAppUpgradeButton({ upgradeId }: { upgradeId: string }) {
+    return this.page.getByTestId(`app-upgrade-${upgradeId}`);
+  }
+
   async clickAppUpgradeButton({ upgradeId }: { upgradeId: string }) {
-    await this.page.getByTestId(`app-upgrade-${upgradeId}`).click();
+    await this.locateAppUpgradeButton({ upgradeId }).click();
+  }
+
+  async expectAppUpgradeButtonIsNotVisible({
+    upgradeId,
+  }: {
+    upgradeId: string;
+  }) {
+    await expect(this.locateAppUpgradeButton({ upgradeId })).toBeHidden({
+      timeout: Timeout.MEDIUM,
+    });
   }
 
   async expectNoAppUpgrades() {
diff --git a/e2e-tests/select_component.spec.ts b/e2e-tests/select_component.spec.ts
index d01b47f..d87d902 100644
--- a/e2e-tests/select_component.spec.ts
+++ b/e2e-tests/select_component.spec.ts
@@ -58,7 +58,9 @@ testSkipIfWindows("upgrade app to select component", async ({ po }) => {
   await po.importApp("select-component");
   await po.getTitleBarAppNameButton().click();
   await po.clickAppUpgradeButton({ upgradeId: "component-tagger" });
-  await po.expectNoAppUpgrades();
+  await po.expectAppUpgradeButtonIsNotVisible({
+    upgradeId: "component-tagger",
+  });
   await po.snapshotAppFiles();
   await po.clickOpenInChatButton();
   // There should be another version from the upgrade being committed.
diff --git a/playwright.config.ts b/playwright.config.ts
index beda284..3b01438 100644
--- a/playwright.config.ts
+++ b/playwright.config.ts
@@ -3,7 +3,7 @@ import { PlaywrightTestConfig } from "@playwright/test";
 const config: PlaywrightTestConfig = {
   testDir: "./e2e-tests",
   workers: 1,
-  retries: process.env.CI ? 2 : 0,
+  retries: process.env.CI ? 2 : 1,
   // maxFailures: 1,
   timeout: process.env.CI ? 180_000 : 30_000,
   // Use a custom snapshot path template because Playwright's default