kunthawat/moreminimore-vibe
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Shard E2E tests (#941)

Browse Source
This commit is contained in:
Will Chen
2025-08-14 13:48:27 -07:00
committed by GitHub
parent cc72990f0d
commit 8ef84285fc
7 changed files with 124 additions and 62 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
e2e-tests/delete_app.spec.ts
View File

@@ -1,6 +1,7 @@
import fs from "fs";
import { test } from "./helpers/test_helper";
import { expect } from "@playwright/test";
test("delete app", async ({ po }) => {
await po.setUp();
await po.sendPrompt("hi");

66
e2e-tests/helpers/test_helper.ts
View File

@@ -251,58 +251,52 @@ export class PageObject {
await this.goToAppsTab();
}
async runPnpmInstall() {
async ensurePnpmInstall() {
const appPath = await this.getCurrentAppPath();
if (!appPath) {
throw new Error("No app selected");
}
const maxRetries = 3;
let lastError: any;
const maxDurationMs = 180_000; // 3 minutes
const retryIntervalMs = 15_000;
const startTime = Date.now();
let lastOutput = "";
for (let attempt = 1; attempt <= maxRetries; attempt++) {
const checkCommand = `node -e 'const pkg=require("./package.json");const{execSync}=require("child_process");try{const prodResult=JSON.parse(execSync("pnpm list --json --depth=0",{encoding:"utf8"}));const devResult=JSON.parse(execSync("pnpm list --json --depth=0 --dev",{encoding:"utf8"}));const installed={...(prodResult[0]||{}).dependencies||{},...(devResult[0]||{}).devDependencies||{}};const expected=Object.keys({...pkg.dependencies||{},...pkg.devDependencies||{}});const missing=expected.filter(dep=>!installed[dep]);console.log(missing.length?"MISSING: "+missing.join(", "):"All dependencies installed")}catch(e){console.log("Error:",e.message)}'`;
while (Date.now() - startTime < maxDurationMs) {
try {
console.log(
`Running 'pnpm install' in ${appPath} (attempt ${attempt}/${maxRetries})`,
);
execSync("pnpm install", {
console.log(`Checking installed dependencies in ${appPath}...`);
const stdout = execSync(checkCommand, {
cwd: appPath,
stdio: "pipe",
encoding: "utf8",
});
console.log(`'pnpm install' succeeded on attempt ${attempt}`);
return; // Success, exit the function
lastOutput = (stdout || "").toString().trim();
console.log(`Dependency check output: ${lastOutput}`);
if (lastOutput.includes("All dependencies installed")) {
return;
}
} catch (error: any) {
lastError = error;
console.error(
`Attempt ${attempt}/${maxRetries} failed to run 'pnpm install' in ${appPath}`,
);
console.error(`Exit code: ${error.status}`);
console.error(`Command: ${error.cmd || "pnpm install"}`);
if (error.stdout) {
console.error(`STDOUT:\n${error.stdout}`);
}
if (error.stderr) {
console.error(`STDERR:\n${error.stderr}`);
}
// If this wasn't the last attempt, wait a bit before retrying
if (attempt < maxRetries) {
const delayMs = 1000 * attempt; // Exponential backoff: 1s, 2s
console.log(`Waiting ${delayMs}ms before retry...`);
await new Promise((resolve) => setTimeout(resolve, delayMs));
}
// Capture any error output to include in the final error if we time out
const stdOut = error?.stdout ? error.stdout.toString() : "";
const stdErr = error?.stderr ? error.stderr.toString() : "";
lastOutput = [stdOut, stdErr, error?.message]
.filter(Boolean)
.join("\n");
console.error("Dependency check command failed:", lastOutput);
}
const elapsed = Date.now() - startTime;
const remaining = Math.max(0, maxDurationMs - elapsed);
const waitMs = Math.min(retryIntervalMs, remaining);
if (waitMs <= 0) break;
console.log(`Waiting ${waitMs}ms before retry...`);
await new Promise((resolve) => setTimeout(resolve, waitMs));
}
// All attempts failed, throw the last error with enhanced message
throw new Error(
`pnpm install failed in ${appPath} after ${maxRetries} attempts. ` +
`Exit code: ${lastError.status}. ` +
`${lastError.stderr ? `Error: ${lastError.stderr}` : ""}` +
`${lastError.stdout ? ` Output: ${lastError.stdout}` : ""}`,
`Dependencies not fully installed in ${appPath} after 3 minutes. Last output: ${lastOutput}`,
);
}

14
e2e-tests/problems.spec.ts
View File

@@ -1,4 +1,4 @@
import { test } from "./helpers/test_helper";
import { test, testSkipIfWindows } from "./helpers/test_helper";
import { expect } from "@playwright/test";
import fs from "fs";
import path from "path";
@@ -58,7 +58,7 @@ test("problems auto-fix - disabled", async ({ po }) => {
await po.snapshotMessages();
});
test("problems - fix all", async ({ po }) => {
testSkipIfWindows("problems - fix all", async ({ po }) => {
await po.setUp({ enableAutoFixProblems: true });
await po.importApp(MINIMAL_APP);
const appPath = await po.getCurrentAppPath();
@@ -73,7 +73,7 @@ nonExistentFunction3();
export default App;
`,
);
await po.runPnpmInstall();
await po.ensurePnpmInstall();
await po.sendPrompt("tc=create-ts-errors");
await po.selectPreviewMode("problems");
@@ -83,7 +83,7 @@ export default App;
await po.snapshotMessages({ replaceDumpPath: true });
});
test("problems - manual edit (react/vite)", async ({ po }) => {
testSkipIfWindows("problems - manual edit (react/vite)", async ({ po }) => {
await po.setUp({ enableAutoFixProblems: true });
await po.sendPrompt("tc=1");
@@ -97,7 +97,7 @@ nonExistentFunction();
export default App;
`,
);
await po.runPnpmInstall();
await po.ensurePnpmInstall();
await po.clickTogglePreviewPanel();
await po.selectPreviewMode("problems");
@@ -110,7 +110,7 @@ export default App;
await po.snapshotProblemsPane();
});
test("problems - manual edit (next.js)", async ({ po }) => {
testSkipIfWindows("problems - manual edit (next.js)", async ({ po }) => {
await po.setUp({ enableAutoFixProblems: true });
await po.goToHubAndSelectTemplate("Next.js Template");
await po.sendPrompt("tc=1");
@@ -125,7 +125,7 @@ test("problems - manual edit (next.js)", async ({ po }) => {
export default App;
`,
);
await po.runPnpmInstall();
await po.ensurePnpmInstall();
await po.clickTogglePreviewPanel();
await po.selectPreviewMode("problems");