kunthawat/moreminimore-vibe
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix Azure e2e test so it doesn't leak (#1248)

Browse Source 
<!-- This is an auto-generated description by cubic. -->

## Summary by cubic
Scoped Azure e2e test env setup to prevent leaking variables across
tests. Added testWithConfigSkipIfWindows and moved Azure env vars into a
per-test preLaunchHook; the Azure test now skips on Windows.

<!-- End of auto-generated description by cubic. -->
This commit is contained in:
Will Chen
2025-09-10 14:48:15 -07:00
committed by GitHub
parent 72acb31d59
commit 9bc5e1387a
2 changed files with 21 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
e2e-tests/azure_send_message.spec.ts
View File

@@ -1,11 +1,16 @@
import { testSkipIfWindows } from "./helpers/test_helper"; import { testWithConfigSkipIfWindows } from "./helpers/test_helper";
// Set environment variables before the test runs to enable Azure testing // Set environment variables before the test runs to enable Azure testing
const testAzure = testWithConfigSkipIfWindows({
preLaunchHook: async () => {
process.env.TEST_AZURE_BASE_URL = "http://localhost:3500/azure"; process.env.TEST_AZURE_BASE_URL = "http://localhost:3500/azure";
process.env.AZURE_API_KEY = "fake-azure-key-for-testing"; process.env.AZURE_API_KEY = "fake-azure-key-for-testing";
process.env.AZURE_RESOURCE_NAME = "fake-resource-for-testing"; process.env.AZURE_RESOURCE_NAME = "fake-resource-for-testing";
},
});
testSkipIfWindows("send message through Azure OpenAI", async ({ po }) => { testAzure("send message through Azure OpenAI", async ({ po }) => {
// Set up Azure without test provider // Set up Azure without test provider
await po.setUpAzure(); await po.setUpAzure();

11
e2e-tests/helpers/test_helper.ts
View File

@@ -1152,6 +1152,17 @@ export function testWithConfig(config: ElectronConfig) {
}); });
} }
export function testWithConfigSkipIfWindows(config: ElectronConfig) {
if (os.platform() === "win32") {
return test.skip;
}
return test.extend({
electronConfig: async ({}, use) => {
await use(config);
},
});
}
// Wrapper that skips tests on Windows platform // Wrapper that skips tests on Windows platform
export const testSkipIfWindows = os.platform() === "win32" ? test.skip : test; export const testSkipIfWindows = os.platform() === "win32" ? test.skip : test;