Security Panel MVP (#1660)
TODOs: - [x] Add documentation - [x] e2e tests: run security review, update knowledge, and fix issue - [x] more stringent risk rating <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Introduces a new Security mode with a Security Review panel that runs reviews, edits rules, parses findings via IPC, and supports fixing issues, with tests and prompt/runtime support. > > - **UI/Preview Panel**: > - Add `security` preview mode to `previewModeAtom` and ActionHeader (Shield button). > - New `SecurityPanel` showing findings table (sorted by severity), run review, fix issue flow, and edit `SECURITY_RULES.md` dialog. > - Wire into `PreviewPanel` content switch. > - **Hooks**: > - `useSecurityReview(appId)`: fetch latest review via IPC. > - `useStreamChat`: add `onSettled` callback to invoke refreshes after streams. > - **IPC/Main**: > - `security_handlers`: `get-latest-security-review` parses `<dyad-security-finding>` from latest assistant message. > - Register handler in `ipc_host`; expose channel in `preload`. > - `ipc_client`: add `getLatestSecurityReview(appId)`. > - `chat_stream_handlers`: detect `/security-review`, use dedicated system prompt, optionally append `SECURITY_RULES.md`, suppress Supabase-not-available note in this mode. > - **Prompts**: > - Add `SECURITY_REVIEW_SYSTEM_PROMPT` with structured finding output. > - **Supabase**: > - Enhance schema query to include `rls_enabled`, split policy `using_clause`/`with_check_clause`. > - **E2E Tests**: > - New `security_review.spec.ts` plus snapshots and fixture findings; update test helper for `security` mode and findings table snapshot. > - Fake LLM server streams security findings for `/security-review` and increases batch size. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 5022d01e22a2dd929a968eeba0da592e0aeece01. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
This commit is contained in:
20
src/hooks/useSecurityReview.ts
Normal file
20
src/hooks/useSecurityReview.ts
Normal file
@@ -0,0 +1,20 @@
|
||||
import { useQuery } from "@tanstack/react-query";
|
||||
import { IpcClient } from "@/ipc/ipc_client";
|
||||
|
||||
export function useSecurityReview(appId: number | null) {
|
||||
return useQuery({
|
||||
queryKey: ["security-review", appId],
|
||||
queryFn: async () => {
|
||||
if (!appId) {
|
||||
throw new Error("App ID is required");
|
||||
}
|
||||
const ipcClient = IpcClient.getInstance();
|
||||
return ipcClient.getLatestSecurityReview(appId);
|
||||
},
|
||||
enabled: appId !== null,
|
||||
retry: false,
|
||||
meta: {
|
||||
showErrorToast: false, // Don't show error toast if no security review found
|
||||
},
|
||||
});
|
||||
}
|
||||
@@ -70,12 +70,14 @@ export function useStreamChat({
|
||||
redo,
|
||||
attachments,
|
||||
selectedComponent,
|
||||
onSettled,
|
||||
}: {
|
||||
prompt: string;
|
||||
chatId: number;
|
||||
redo?: boolean;
|
||||
attachments?: FileAttachment[];
|
||||
selectedComponent?: ComponentSelection | null;
|
||||
onSettled?: () => void;
|
||||
}) => {
|
||||
if (
|
||||
(!prompt.trim() && (!attachments || attachments.length === 0)) ||
|
||||
@@ -153,6 +155,7 @@ export function useStreamChat({
|
||||
refreshApp();
|
||||
refreshVersions();
|
||||
countTokens(chatId, "");
|
||||
onSettled?.();
|
||||
},
|
||||
onError: (errorMessage: string) => {
|
||||
console.error(`[CHAT] Stream error for ${chatId}:`, errorMessage);
|
||||
@@ -172,6 +175,7 @@ export function useStreamChat({
|
||||
refreshApp();
|
||||
refreshVersions();
|
||||
countTokens(chatId, "");
|
||||
onSettled?.();
|
||||
},
|
||||
});
|
||||
} catch (error) {
|
||||
@@ -190,6 +194,7 @@ export function useStreamChat({
|
||||
);
|
||||
return next;
|
||||
});
|
||||
onSettled?.();
|
||||
}
|
||||
},
|
||||
[
|
||||
|
||||
Reference in New Issue
Block a user