From d0c410859ddc3165ee127025525991ef529864e1 Mon Sep 17 00:00:00 2001
From: Will Chen <willchen90@gmail.com>
Date: Mon, 5 May 2025 15:12:46 -0700
Subject: [PATCH] clean-up release scripts (#86)

---
 .github/workflows/release.yml |  8 ++++----
 forge.config.ts               | 10 ----------
 2 files changed, 4 insertions(+), 14 deletions(-)

diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
index f0cbd1f..4912c22 100644
--- a/.github/workflows/release.yml
+++ b/.github/workflows/release.yml
@@ -12,9 +12,10 @@ jobs:
   build:
     environment: release
     strategy:
-      # Do it sequentially to avoid a race condition where multiple release drafts
-      # for the same version are created in parallel.
-      max-parallel: 1
+      # Uncomment max-parallel to prevent race condition (where multiple releases are
+      # created concurrently). Typically though, we'll create a release manually ahead of time
+      # which prevents the race.
+      # max-parallel: 1
       matrix:
         os:
           [
@@ -47,7 +48,6 @@ jobs:
       - name: Set variables
         if: contains(matrix.os.name, 'windows')
         id: variables
-        # echo "version=${GITHUB_REF#refs/tags/v}" >> $GITHUB_OUTPUT
         run: |
           echo "SM_HOST=${{ secrets.SM_HOST }}" >> "$GITHUB_ENV" 
           echo "SM_API_KEY=${{ secrets.SM_API_KEY }}" >> "$GITHUB_ENV" 
diff --git a/forge.config.ts b/forge.config.ts
index 1bf7cef..b100452 100644
--- a/forge.config.ts
+++ b/forge.config.ts
@@ -69,16 +69,6 @@ const config: ForgeConfig = {
   makers: [
     new MakerSquirrel({
       signWithParams: `/sha1 ${process.env.SM_CODE_SIGNING_CERT_SHA1_HASH} /tr http://timestamp.digicert.com /td SHA256 /fd SHA256`,
-
-      // signWithParams: `/csp "DigiCert Signing Manager KSP" /kc ${process.env.DIGICERT_KEYPAIR_ALIAS} /f ${process.env.SM_CLIENT_CERT_FILE} /tr http://timestamp.digicert.com /td SHA256 /fd SHA256`,
-      // windowsSign: {
-
-      // certificateFile: process.env.SM_CLIENT_CERT_FILE,
-      // certificatePassword: process.env.SM_CLIENT_CERT_PASSWORD,
-      // signToolPath:
-      //   "C:\\Program Files\\DigiCert\\DigiCert Keylocker Tools\\smctl.exe",
-      // signWithParams: `/sha1 ${process.env.SM_CODE_SIGNING_CERT_SHA1_HASH} /tr http://timestamp.digicert.com /td SHA256 /fd SHA256`,
-      // },
     }),
     new MakerZIP({}, ["darwin"]),
     new MakerRpm({}),