From df74c52ca9173c36f11ab1934dc00660de334960 Mon Sep 17 00:00:00 2001
From: Will Chen <willchen90@gmail.com>
Date: Thu, 10 Jul 2025 14:37:21 -0700
Subject: [PATCH] Split supbase migration into two test cases (#623)

---
 e2e-tests/supabase_migrations.spec.ts | 78 ++++++++++++++++++++++-----
 1 file changed, 66 insertions(+), 12 deletions(-)

diff --git a/e2e-tests/supabase_migrations.spec.ts b/e2e-tests/supabase_migrations.spec.ts
index a257c2c..174a42a 100644
--- a/e2e-tests/supabase_migrations.spec.ts
+++ b/e2e-tests/supabase_migrations.spec.ts
@@ -1,11 +1,69 @@
 import { expect } from "@playwright/test";
-import { test } from "./helpers/test_helper";
+import { test, testSkipIfWindows } from "./helpers/test_helper";
 import fs from "fs-extra";
 import path from "path";
 import { execSync } from "child_process";
-import os from "node:os";
 
 test("supabase migrations", async ({ po }) => {
+  await po.setUp({ autoApprove: true });
+  await po.sendPrompt("tc=add-supabase");
+
+  // Connect to Supabase
+  await po.page.getByText("Set up supabase").click();
+  await po.clickConnectSupabaseButton();
+  await po.clickBackButton();
+
+  const appPath = await po.getCurrentAppPath();
+  const migrationsDir = path.join(appPath, "supabase", "migrations");
+
+  // --- SCENARIO 1: OFF BY DEFAULT ---
+  await po.sendPrompt("tc=execute-sql-1");
+  await po.waitForChatCompletion();
+
+  expect(fs.existsSync(migrationsDir)).toBe(false);
+
+  // --- SCENARIO 2: TOGGLE ON ---
+  // Go to settings to find the Supabase integration
+  await po.goToSettingsTab();
+  const migrationsSwitch = po.page.locator("#supabase-migrations");
+  await migrationsSwitch.click();
+  await po.goToChatTab();
+
+  // Send a prompt that triggers a migration
+  await po.sendPrompt("tc=execute-sql-1");
+  await po.waitForChatCompletion();
+
+  let files: string[] = [];
+  await expect(async () => {
+    // Check that one migration file was created
+    files = await fs.readdir(migrationsDir);
+    expect(files).toHaveLength(1);
+  }).toPass();
+
+  expect(files[0]).toMatch(/0000_create_users_table\.sql/);
+  expect(await fs.readFile(path.join(migrationsDir, files[0]), "utf8")).toEqual(
+    "CREATE TABLE users (id serial primary key);",
+  );
+
+  // Send a prompt that triggers a migration
+  await po.sendPrompt("tc=execute-sql-no-description");
+  await po.waitForChatCompletion();
+
+  await expect(async () => {
+    // Check that one migration file was created
+    files = await fs.readdir(migrationsDir);
+    expect(files).toHaveLength(2);
+  }).toPass();
+
+  expect(files[1]).toMatch(/0001_\w+_\w+_\w+\.sql/);
+  expect(await fs.readFile(path.join(migrationsDir, files[1]), "utf8")).toEqual(
+    "DROP TABLE users;",
+  );
+});
+
+// Skip this test on Windows because git isn't configured and
+// the mac test will catch this regression.
+testSkipIfWindows("supabase migrations with native git", async ({ po }) => {
   // Turning on native Git to catch this edge case:
   // https://github.com/dyad-sh/dyad/issues/608
   await po.setUp({ autoApprove: true, nativeGit: true });
@@ -48,16 +106,12 @@ test("supabase migrations", async ({ po }) => {
     "CREATE TABLE users (id serial primary key);",
   );
 
-  // Skip this check on Windows because git isn't configured and
-  // the mac test will catch this regression.
-  if (os.platform() !== "win32") {
-    // Make sure git is clean.
-    const gitStatus = execSync("git status --porcelain", {
-      cwd: appPath,
-      encoding: "utf8",
-    }).trim();
-    expect(gitStatus).toBe("");
-  }
+  // Make sure git is clean.
+  const gitStatus = execSync("git status --porcelain", {
+    cwd: appPath,
+    encoding: "utf8",
+  }).trim();
+  expect(gitStatus).toBe("");
 
   // Send a prompt that triggers a migration
   await po.sendPrompt("tc=execute-sql-no-description");