From e060f780b9ff69ad28e249dd6a943d3eefe03116 Mon Sep 17 00:00:00 2001
From: Will Chen <willchen90@gmail.com>
Date: Tue, 3 Jun 2025 22:26:39 -0700
Subject: [PATCH] Use npm install --legacy-peer-deps (#326)

Fixes #309

Unfortunately a lot of React.js apps have this problem with peer deps
because older dependencies specify pre-v19. Because Dyad app templates
do (and should) explicitly specify React as a dependnecy, using
`--legacy-peer-deps` gives us the right behavior where it effectively
does not install peer deps and avoids the React version errors.

For pnpm, we have an explicit lockfiles for our templates so there isn't
an issue.

Context:
https://stackoverflow.com/questions/66239691/what-does-npm-install-legacy-peer-deps-do-exactly-when-is-it-recommended-wh

---------

Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>
---
 src/ipc/handlers/app_handlers.ts           | 2 +-
 src/ipc/processors/executeAddDependency.ts | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/ipc/handlers/app_handlers.ts b/src/ipc/handlers/app_handlers.ts
index c978546..210e810 100644
--- a/src/ipc/handlers/app_handlers.ts
+++ b/src/ipc/handlers/app_handlers.ts
@@ -69,7 +69,7 @@ async function executeAppLocalNode({
   event: Electron.IpcMainInvokeEvent;
 }): Promise<void> {
   const process = spawn(
-    "(pnpm install && pnpm run dev --port 32100) || (npm install && npm run dev -- --port 32100)",
+    "(pnpm install && pnpm run dev --port 32100) || (npm install --legacy-peer-deps && npm run dev -- --port 32100)",
     [],
     {
       cwd: appPath,
diff --git a/src/ipc/processors/executeAddDependency.ts b/src/ipc/processors/executeAddDependency.ts
index f13666e..5ffe3c0 100644
--- a/src/ipc/processors/executeAddDependency.ts
+++ b/src/ipc/processors/executeAddDependency.ts
@@ -19,7 +19,7 @@ export async function executeAddDependency({
   const packageStr = packages.join(" ");
 
   const { stdout, stderr } = await execPromise(
-    `(pnpm add ${packageStr}) || (npm install ${packageStr})`,
+    `(pnpm add ${packageStr}) || (npm install --legacy-peer-deps ${packageStr})`,
     {
       cwd: appPath,
     },