Skip failing windows test (#332)

This commit is contained in:
Will Chen
2025-06-04 10:31:13 -07:00
committed by GitHub
parent 69b0e7aba2
commit e91a9c44fa
11 changed files with 28 additions and 24 deletions

View File

@@ -1,7 +1,7 @@
import { test, Timeout } from "./helpers/test_helper"; import { testSkipIfWindows, Timeout } from "./helpers/test_helper";
import { expect } from "@playwright/test"; import { expect } from "@playwright/test";
test("write to index, approve, check preview", async ({ po }) => { testSkipIfWindows("write to index, approve, check preview", async ({ po }) => {
await po.setUp(); await po.setUp();
await po.sendPrompt("tc=write-index"); await po.sendPrompt("tc=write-index");
await po.snapshotMessages(); await po.snapshotMessages();

View File

@@ -1,7 +1,7 @@
import { test, Timeout } from "./helpers/test_helper"; import { testSkipIfWindows, Timeout } from "./helpers/test_helper";
import { expect } from "@playwright/test"; import { expect } from "@playwright/test";
test("auto-approve", async ({ po }) => { testSkipIfWindows("auto-approve", async ({ po }) => {
await po.setUp({ autoApprove: true }); await po.setUp({ autoApprove: true });
await po.sendPrompt("tc=write-index"); await po.sendPrompt("tc=write-index");
await po.snapshotMessages(); await po.snapshotMessages();

View File

@@ -1,6 +1,6 @@
import { test } from "./helpers/test_helper"; import { testSkipIfWindows } from "./helpers/test_helper";
test("context window", async ({ po }) => { testSkipIfWindows("context window", async ({ po }) => {
await po.setUp(); await po.setUp();
await po.sendPrompt("tc=1"); await po.sendPrompt("tc=1");
await po.sendPrompt("tc=2"); await po.sendPrompt("tc=2");

View File

@@ -1,6 +1,6 @@
import { test } from "./helpers/test_helper"; import { testSkipIfWindows } from "./helpers/test_helper";
test("send message to engine", async ({ po }) => { testSkipIfWindows("send message to engine", async ({ po }) => {
await po.setUpDyadPro(); await po.setUpDyadPro();
// By default, it's using auto which points to Flash 2.5 and doesn't // By default, it's using auto which points to Flash 2.5 and doesn't
// use engine. // use engine.
@@ -11,7 +11,7 @@ test("send message to engine", async ({ po }) => {
await po.snapshotMessages({ replaceDumpPath: true }); await po.snapshotMessages({ replaceDumpPath: true });
}); });
test("send message to gateway", async ({ po }) => { testSkipIfWindows("send message to gateway", async ({ po }) => {
await po.setUpDyadPro(); await po.setUpDyadPro();
await po.selectModel({ provider: "Google", model: "Gemini 2.5 Flash" }); await po.selectModel({ provider: "Google", model: "Gemini 2.5 Flash" });
await po.sendPrompt("[dump] tc=gateway-simple"); await po.sendPrompt("[dump] tc=gateway-simple");
@@ -21,7 +21,7 @@ test("send message to gateway", async ({ po }) => {
}); });
// auto (defaults to Gemini 2.5 Flash) // auto (defaults to Gemini 2.5 Flash)
test("auto should send message to gateway", async ({ po }) => { testSkipIfWindows("auto should send message to gateway", async ({ po }) => {
await po.setUpDyadPro(); await po.setUpDyadPro();
await po.sendPrompt("[dump] tc=gateway-simple"); await po.sendPrompt("[dump] tc=gateway-simple");

View File

@@ -536,7 +536,11 @@ export const test = base.extend<{
// Windows' strict resource locking (e.g. file locking). // Windows' strict resource locking (e.g. file locking).
if (os.platform() === "win32") { if (os.platform() === "win32") {
try { try {
execSync("taskkill /f /im dyad.exe"); console.log("[cleanup:start] Killing dyad.exe");
console.time("taskkill");
execSync("taskkill /f /t /im dyad.exe");
console.timeEnd("taskkill");
console.log("[cleanup:end] Killed dyad.exe");
} catch (error) { } catch (error) {
console.warn( console.warn(
"Failed to kill dyad.exe: (continuing with test cleanup)", "Failed to kill dyad.exe: (continuing with test cleanup)",

View File

@@ -1,8 +1,8 @@
import path from "path"; import path from "path";
import { test } from "./helpers/test_helper"; import { testSkipIfWindows } from "./helpers/test_helper";
import * as eph from "electron-playwright-helpers"; import * as eph from "electron-playwright-helpers";
test("import app", async ({ po }) => { testSkipIfWindows("import app", async ({ po }) => {
await po.setUp(); await po.setUp();
await po.page.getByRole("button", { name: "Import App" }).click(); await po.page.getByRole("button", { name: "Import App" }).click();
await eph.stubDialog(po.electronApp, "showOpenDialog", { await eph.stubDialog(po.electronApp, "showOpenDialog", {
@@ -20,7 +20,7 @@ test("import app", async ({ po }) => {
await po.snapshotMessages(); await po.snapshotMessages();
}); });
test("import app with AI rules", async ({ po }) => { testSkipIfWindows("import app with AI rules", async ({ po }) => {
await po.setUp(); await po.setUp();
await po.page.getByRole("button", { name: "Import App" }).click(); await po.page.getByRole("button", { name: "Import App" }).click();
await eph.stubDialog(po.electronApp, "showOpenDialog", { await eph.stubDialog(po.electronApp, "showOpenDialog", {

View File

@@ -1,9 +1,9 @@
import { test, Timeout } from "./helpers/test_helper"; import { testSkipIfWindows, Timeout } from "./helpers/test_helper";
import { expect } from "@playwright/test"; import { expect } from "@playwright/test";
import fs from "fs"; import fs from "fs";
import path from "path"; import path from "path";
test("rebuild app", async ({ po }) => { testSkipIfWindows("rebuild app", async ({ po }) => {
await po.setUp({ autoApprove: true }); await po.setUp({ autoApprove: true });
await po.sendPrompt("hi"); await po.sendPrompt("hi");
await po.snapshotPreview(); await po.snapshotPreview();

View File

@@ -1,6 +1,6 @@
import { test } from "./helpers/test_helper"; import { testSkipIfWindows } from "./helpers/test_helper";
test("refresh app", async ({ po }) => { testSkipIfWindows("refresh app", async ({ po }) => {
await po.setUp({ autoApprove: true }); await po.setUp({ autoApprove: true });
await po.sendPrompt("hi"); await po.sendPrompt("hi");

View File

@@ -1,7 +1,7 @@
import { test, Timeout } from "./helpers/test_helper"; import { testSkipIfWindows, Timeout } from "./helpers/test_helper";
import { expect } from "@playwright/test"; import { expect } from "@playwright/test";
test("restart app", async ({ po }) => { testSkipIfWindows("restart app", async ({ po }) => {
await po.setUp({ autoApprove: true }); await po.setUp({ autoApprove: true });
await po.sendPrompt("hi"); await po.sendPrompt("hi");

View File

@@ -1,7 +1,7 @@
import { test } from "./helpers/test_helper"; import { testSkipIfWindows } from "./helpers/test_helper";
import { expect } from "@playwright/test"; import { expect } from "@playwright/test";
test("switch versions", async ({ po }) => { testSkipIfWindows("switch versions", async ({ po }) => {
await po.setUp({ autoApprove: true }); await po.setUp({ autoApprove: true });
await po.sendPrompt("tc=write-index"); await po.sendPrompt("tc=write-index");

View File

@@ -1,7 +1,7 @@
import { test, Timeout } from "./helpers/test_helper"; import { testSkipIfWindows, Timeout } from "./helpers/test_helper";
import { expect } from "@playwright/test"; import { expect } from "@playwright/test";
test("undo", async ({ po }) => { testSkipIfWindows("undo", async ({ po }) => {
await po.setUp({ autoApprove: true }); await po.setUp({ autoApprove: true });
await po.sendPrompt("tc=write-index"); await po.sendPrompt("tc=write-index");
await po.sendPrompt("tc=write-index-2"); await po.sendPrompt("tc=write-index-2");