c50527b4c0
TODOs: - [x] Add documentation - [x] e2e tests: run security review, update knowledge, and fix issue - [x] more stringent risk rating <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Introduces a new Security mode with a Security Review panel that runs reviews, edits rules, parses findings via IPC, and supports fixing issues, with tests and prompt/runtime support. > > - **UI/Preview Panel**: > - Add `security` preview mode to `previewModeAtom` and ActionHeader (Shield button). > - New `SecurityPanel` showing findings table (sorted by severity), run review, fix issue flow, and edit `SECURITY_RULES.md` dialog. > - Wire into `PreviewPanel` content switch. > - **Hooks**: > - `useSecurityReview(appId)`: fetch latest review via IPC. > - `useStreamChat`: add `onSettled` callback to invoke refreshes after streams. > - **IPC/Main**: > - `security_handlers`: `get-latest-security-review` parses `<dyad-security-finding>` from latest assistant message. > - Register handler in `ipc_host`; expose channel in `preload`. > - `ipc_client`: add `getLatestSecurityReview(appId)`. > - `chat_stream_handlers`: detect `/security-review`, use dedicated system prompt, optionally append `SECURITY_RULES.md`, suppress Supabase-not-available note in this mode. > - **Prompts**: > - Add `SECURITY_REVIEW_SYSTEM_PROMPT` with structured finding output. > - **Supabase**: > - Enhance schema query to include `rls_enabled`, split policy `using_clause`/`with_check_clause`. > - **E2E Tests**: > - New `security_review.spec.ts` plus snapshots and fixture findings; update test helper for `security` mode and findings table snapshot. > - Fake LLM server streams security findings for `/security-review` and increases batch size. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 5022d01e22a2dd929a968eeba0da592e0aeece01. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
45 lines
1.2 KiB
YAML
45 lines
1.2 KiB
YAML
- paragraph: "Please fix the following security issue in a simple and effective way:"
|
|
- paragraph:
|
|
- strong: SQL Injection in User Lookup
|
|
- text: (critical severity)
|
|
- paragraph:
|
|
- strong: What
|
|
- text: ": User input flows directly into database queries without validation, allowing attackers to execute arbitrary SQL commands"
|
|
- paragraph:
|
|
- strong: Risk
|
|
- text: ": An attacker could steal all customer data, delete your entire database, or take over admin accounts by manipulating the URL"
|
|
- paragraph:
|
|
- strong: Potential Solutions
|
|
- text: ":"
|
|
- list:
|
|
- listitem:
|
|
- text: "Use parameterized queries:"
|
|
- code: "`db.query('SELECT * FROM users WHERE id = ?', [userId])`"
|
|
- listitem:
|
|
- text: Add input validation to ensure
|
|
- code: "`userId`"
|
|
- text: is a number
|
|
- listitem: Implement an ORM like Prisma or TypeORM that prevents SQL injection by default
|
|
- paragraph:
|
|
- strong: Relevant Files
|
|
- text: ":"
|
|
- code: "`src/api/users.ts`"
|
|
- img
|
|
- text: file1.txt
|
|
- button "Edit":
|
|
- img
|
|
- img
|
|
- text: file1.txt
|
|
- paragraph: More EOM
|
|
- button:
|
|
- img
|
|
- img
|
|
- text: Approved
|
|
- img
|
|
- text: less than a minute ago
|
|
- img
|
|
- text: wrote 1 file(s)
|
|
- button "Undo":
|
|
- img
|
|
- button "Retry":
|
|
- img |