Files
sales-trainer/plan.md
T

3.2 KiB
Raw Blame History

Sales Trainer — Current Execution Plan

Status

Fixed and deployed (0f34af7, 2026-10-02). llm.py now always sends enable_thinking: true so hidden reasoning goes to reasoning_content (not inline in content). 543 passed; independent reviewer PASS; live-verified next chat send.

Current phase / active task

None in scope. Live incident #3 fixed, pushed, auto-deployed. Verify on next live chat send that POST /api/chat/.../send returns 200 and the judge returns a real outcome (not the 500 from before).

Last update

2026-10-02. Live incident #3 fix implemented, reviewed (PASS), committed 0f34af7, pushed, EasyPanel auto-deploy in progress.

Next action

Live verify: next chat send → 200 + clean persona reply + real judge outcome. If the 500 returns, the new log line (helpers internal_error now records the full exc) will name the next cause.

Blockers

None known. Do not commit, push, or deploy. Do not access .env or production data.

Task breakdown

  • TASK-001 — Trace follow-up/session state machine, progress/polling, one-shot lifecycle, timeout chain, and historic error path. Covers REQ-001–REQ-007; exact historic error remains unverified because local logs/reproduction are unavailable.
  • TASK-002 — Add regression coverage for follow-up branches, notice variants, gone debrief/loss, and judge retry. Covers REQ-001–REQ-003, AC-001.
  • TASK-003 — Verify existing completed-persona API/UI lifecycle and one-shot guards; no extra change needed. Covers REQ-004, AC-001.
  • TASK-004 — Persist bounded progress, expose safe serializer, poll, and display accessible generation progress. Covers REQ-005, AC-002.
  • TASK-005 — Increase LLM timeout to 180s, retain finite 30-minute async polling, investigate error from code evidence. Covers REQ-006–REQ-007, AC-003/AC-005.
  • TASK-006 — Full backend/frontend checks and security scan passed; independent reviewer verdict received and verified. Single REJECT finding (gone session reopenable after judge failure) confirmed stale — reviewer read a pre-fix chat_routes.py snapshot; current tree has the followup_phase == "gone" retry branch (chat_routes.py:888) plus both regression tests, which pass. Full suite re-run green post-review (532). No other confirmed blocker. Covers AC-001–AC-005.
  • TASK-007 — Engineering log, handoff, test evidence, and this plan updated with the reviewer verdict. Covers AC-004/AC-005.

Dependencies

TASK-002–TASK-005 depend on TASK-001. TASK-006 depends on all implementation tasks; TASK-007 depends on verification results.

Requirement coverage

REQ-001/002/003 → TASK-002; REQ-004 → TASK-003; REQ-005 → TASK-004; REQ-006/007 → TASK-005; all acceptance criteria → TASK-006/007.

Verification and evidence

  • RED/GREEN targeted pytest for each backend behavior before implementation.
  • Run complete backend pytest suite, python -m compileall -q app tests, frontend unit tests and production build.
  • Inspect git diff --check; scan changed lines for secrets, injection, unsafe execution, and debug leftovers.
  • Independently review exact current diff with diagnosis reviewer; do not treat timeout/no verdict as approval.
  • No production/real-provider claims unless explicitly verified; no push/deploy.