From 51400f20c75001ac83704f96537b99de011645b6 Mon Sep 17 00:00:00 2001 From: Kunthawat Greethong Date: Sat, 29 Aug 2026 11:14:02 +0700 Subject: [PATCH] docs: record IRPC review verdict (passed) + open no-fixture-fallback tradeoff --- .../2026-08-29-data-source-expansion-and-ui-fix.md | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/docs/engineering-log/2026-08-29-data-source-expansion-and-ui-fix.md b/docs/engineering-log/2026-08-29-data-source-expansion-and-ui-fix.md index 9aed943..cb3c3fb 100644 --- a/docs/engineering-log/2026-08-29-data-source-expansion-and-ui-fix.md +++ b/docs/engineering-log/2026-08-29-data-source-expansion-and-ui-fix.md @@ -54,6 +54,12 @@ and clean. Added: - frontend theme card shows "กำไรสุทธิ IRPC 10.27%" Full suite **368 tests OK**; frontend build clean; live dashboard refining_energy surprise 0.764 driven partly by IRPC margin. +Independent review `deleg_474555e4` **passed: true** (parser/paren/value-key/wiring +all correct, no security/logic errors). Suggestion applied: comment noting +ebitda/roe are display-only. Author also flagged that a single upstream page +failure (strict `_fetch_with_cache` → DashboardError) takes down the whole board — +consistent with the documented no-fixture-fallback policy; left as an open +decision, not silently changed. Deferred (feasibility blocked): REIC (JS SPA/XHR), EPPO (JS/WordPress), NBTC (403 anti-bot), PTTEP (JS shell), PTT/BCP (404/DNS). Need browser/XHR approach, not