Guard onboarding manager behind podcast-only demo mode

backend/api/podcast/handlers/dubbing.py

@@ -29,45 +29,16 @@ from ..models import (
     VoiceCloneResult,
 )
 from services.dubbing import AudioDubbingService
-from ..constants import get_podcast_media_read_dirs, get_podcast_media_dir
 
 router = APIRouter()
 
 _dubbing_executor = ThreadPoolExecutor(max_workers=4, thread_name_prefix="podcast_dubbing")
 
-_DUBBED_AUDIO_SUBDIR = Path("dubbed_audio")
-_LEGACY_DUBBED_AUDIO_DIR = Path(__file__).resolve().parents[3] / "data" / "media" / "dubbed_audio"
+DUBBED_AUDIO_DIR = Path(__file__).resolve().parents[3] / "data" / "media" / "dubbed_audio"
 
 
-def _get_dubbed_audio_dir(user_id: str, *, ensure_exists: bool = False) -> Path:
-    """Resolve tenant-scoped dubbed audio directory under podcast audio media."""
-    base_dir = get_podcast_media_dir("audio", user_id, ensure_exists=ensure_exists)
-    dubbed_dir = (base_dir / _DUBBED_AUDIO_SUBDIR).resolve()
-    if ensure_exists:
-        dubbed_dir.mkdir(parents=True, exist_ok=True)
-    return dubbed_dir
-
-
-def _resolve_dubbed_audio_file(filename: str, user_id: str) -> Path:
-    """Resolve dubbed audio with traversal-safe checks (tenant first, then legacy fallback)."""
-    clean_filename = filename.split("?", 1)[0].strip()
-    if not clean_filename:
-        raise HTTPException(status_code=400, detail="Invalid filename")
-
-    candidate_dirs: list[Path] = []
-    for base_dir in get_podcast_media_read_dirs("audio", user_id):
-        candidate_dirs.append((base_dir / _DUBBED_AUDIO_SUBDIR).resolve())
-    candidate_dirs.append(_LEGACY_DUBBED_AUDIO_DIR.resolve())
-
-    for target_dir in candidate_dirs:
-        candidate = (target_dir / clean_filename).resolve()
-        if not str(candidate).startswith(str(target_dir)):
-            logger.error(f"[Podcast][Dubbing] Attempted path traversal: {filename}")
-            raise HTTPException(status_code=403, detail="Invalid audio path")
-        if candidate.exists():
-            return candidate
-
-    raise HTTPException(status_code=404, detail="Audio file not found")
+def _ensure_dubbed_audio_dir():
+    DUBBED_AUDIO_DIR.mkdir(parents=True, exist_ok=True)
 
 
 def _execute_dubbing_task(
@@ -91,8 +62,9 @@ def _execute_dubbing_task(
             message="Starting audio dubbing..."
         )
         
-        dubbed_audio_dir = _get_dubbed_audio_dir(user_id, ensure_exists=True)
-        service = AudioDubbingService(output_dir=dubbed_audio_dir)
+        _ensure_dubbed_audio_dir()
+        
+        service = AudioDubbingService(output_dir=DUBBED_AUDIO_DIR)
         
         def progress_callback(progress: float, message: str):
             task_manager.update_task_status(
@@ -164,8 +136,9 @@ def _execute_voice_clone_task(
             message="Starting voice cloning..."
         )
         
-        dubbed_audio_dir = _get_dubbed_audio_dir(user_id, ensure_exists=True)
-        service = AudioDubbingService(output_dir=dubbed_audio_dir)
+        _ensure_dubbed_audio_dir()
+        
+        service = AudioDubbingService(output_dir=DUBBED_AUDIO_DIR)
         
         task_manager.update_task_status(
             task_id, "processing", progress=30.0,
@@ -328,7 +301,12 @@ async def serve_dubbed_audio(
     """
     user_id = require_authenticated_user(current_user)
     
-    audio_path = _resolve_dubbed_audio_file(filename, user_id)
+    _ensure_dubbed_audio_dir()
+    
+    audio_path = DUBBED_AUDIO_DIR / filename
+    
+    if not audio_path.exists():
+        raise HTTPException(status_code=404, detail="Audio file not found")
     
     return FileResponse(
         path=audio_path,
@@ -349,8 +327,7 @@ async def estimate_dubbing_cost(
     """
     user_id = require_authenticated_user(current_user)
     
-    dubbed_audio_dir = _get_dubbed_audio_dir(user_id, ensure_exists=True)
-    service = AudioDubbingService(output_dir=dubbed_audio_dir)
+    service = AudioDubbingService(output_dir=DUBBED_AUDIO_DIR)
     
     cost_estimate = service.estimate_cost(
         audio_duration_seconds=request.audio_duration_seconds,
@@ -502,12 +479,12 @@ async def serve_voice_audio(
     """
     user_id = require_authenticated_user(current_user)
     
-    try:
-        audio_path = _resolve_dubbed_audio_file(filename, user_id)
-    except HTTPException as exc:
-        if exc.status_code == 404:
-            raise HTTPException(status_code=404, detail="Voice audio file not found") from exc
-        raise
+    _ensure_dubbed_audio_dir()
+    
+    audio_path = DUBBED_AUDIO_DIR / filename
+    
+    if not audio_path.exists():
+        raise HTTPException(status_code=404, detail="Voice audio file not found")
     
     return FileResponse(
         path=audio_path,

backend/app.py

@@ -48,6 +48,13 @@ load_dotenv(backend_dir / '.env')  # backend/.env
 load_dotenv(project_root / '.env')  # root .env (fallback)
 load_dotenv()  # CWD .env (fallback)
 
+PODCAST_ONLY_DEMO_MODE = os.getenv("PODCAST_ONLY_DEMO_MODE", "false").lower() in {
+    "1",
+    "true",
+    "yes",
+    "on",
+}
+
 # Set up clean logging for end users
 from logging_config import setup_clean_logging
 setup_clean_logging()
@@ -183,7 +190,9 @@ rate_limiter = RateLimiter(window_seconds=60, max_requests=200)
 frontend_serving = FrontendServing(app)
 router_manager = RouterManager(app)
 
-onboarding_manager = OnboardingManager(app)
+onboarding_manager = None
+if not PODCAST_ONLY_DEMO_MODE:
+    onboarding_manager = OnboardingManager(app)
 
 # Middleware Order (FastAPI executes in REVERSE order of registration - LIFO):
 # Registration order:  1. Monitoring  2. Rate Limit  3. API Key Injection
@@ -255,7 +264,14 @@ async def router_status():
 # Onboarding management endpoints
 @app.get("/api/onboarding/status")
 async def onboarding_status():
-    """Get onboarding manager status."""
+    """Get onboarding manager status (or demo-mode disabled state)."""
+    if PODCAST_ONLY_DEMO_MODE:
+        return {
+            "enabled": False,
+            "status": "disabled",
+            "message": "Onboarding is disabled for podcast-only demo mode.",
+            "demo_mode": "podcast_only",
+        }
     return onboarding_manager.get_onboarding_status()
 
 # Include routers using modular utilities