Files
microfish/backend/tests/test_db_url_normalization.py
Kunthawat Greethong fb9275818e fix: normalize bare postgres:// to postgresql+psycopg:// (worker crash-loop)
Root cause (confirmed on local): even with psycopg installed, SQLAlchemy
raises:
  NoSuchModuleError: Can't load plugin: sqlalchemy.dialects:postgres
when DATABASE_URL uses the bare 'postgres://' scheme, because SQLAlchemy
only resolves 'postgresql+driver://'. The deploy's DATABASE_URL was
'postgres://...', so alembic upgrade head (run by the entrypoint before
starting services) crashed and the worker crash-looped in supervisor.

Fix:
- create_database_engine now normalizes 'postgres://' and legacy
  'postgres+pq://' to 'postgresql+psycopg://' so a bare postgres scheme
  works as long as psycopg is installed.
- Dockerfile build step now verifies psycopg imports after 'uv sync'
  (fails the build loudly instead of a runtime crash-loop).
- Tests: 4 for URL normalization; backend suite now 201 passed.
2026-08-31 20:13:16 +07:00

43 lines
1.3 KiB
Python

"""Tests for create_database_engine URL normalization.
Bare `postgres://` and legacy `postgres+pq://` schemes must be normalized to
the explicit `postgresql+psycopg://` dialect, otherwise SQLAlchemy raises
"NoSuchModuleError: Can't load plugin: sqlalchemy.dialects:postgres" even when
psycopg is installed.
"""
from app.db import create_database_engine
def test_normalizes_bare_postgres_scheme():
engine = create_database_engine("postgres://user:pass@db.example.com:5432/mydb")
try:
assert str(engine.url).startswith("postgresql+psycopg://")
assert "user:***@db.example.com:5432/mydb" in str(engine.url)
finally:
engine.dispose()
def test_normalizes_legacy_psycopg2_scheme():
engine = create_database_engine("postgres+pq://user:pass@localhost:5432/db")
try:
assert str(engine.url).startswith("postgresql+psycopg://")
finally:
engine.dispose()
def test_leaves_explicit_psycopg_scheme_unchanged():
engine = create_database_engine("postgresql+psycopg://user:pass@localhost:5432/db")
try:
assert str(engine.url).startswith("postgresql+psycopg://")
finally:
engine.dispose()
def test_leaves_sqlite_unchanged():
engine = create_database_engine("sqlite:////tmp/db-test.sqlite")
try:
assert str(engine.url).startswith("sqlite:")
finally:
engine.dispose()