kunthawat/set50-system
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[verified] Add API tests for /api/v1/learning/factors + configurable history dir

Browse Source 
Closes reviewer suggestion (deleg_5dd358e3): adds coverage for the factor
readiness endpoint (n_points / learnable / last_value / ordering) and the
min_points 400 validation. FACTOR_HISTORY_DIR is now configurable via app
config so tests (and deploy) can point the history store at a chosen path
instead of a hardcoded data dir. 236 tests pass.
This commit is contained in:
Kunthawat Greethong
2026-08-27 07:37:01 +07:00
parent d87a1ada39
commit b362cc35bf
2 changed files with 28 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
backend/app/__init__.py
View File

@@ -790,7 +790,9 @@ def create_app(config: dict[str, Any] | None = None) -> Flask:
"""
from app import factors as factors_mod
from app.factor_history import FactorHistory
fh = FactorHistory(Path(__file__).resolve().parents[1] / "data" / "factor_history")
hist_dir = app.config.get("FACTOR_HISTORY_DIR") or (
Path(__file__).resolve().parents[1] / "data" / "factor_history")
fh = FactorHistory(hist_dir)
try:
min_points = max(int(request.args.get("min_points", "12")), 0)
except (TypeError, ValueError):

25
backend/tests/test_api.py
View File

@@ -495,5 +495,30 @@ class ApiTests(unittest.TestCase):
second_app = create_app(config)
entries = second_app.test_client().get("/api/v1/paper/ledger").get_json()["entries"]
self.assertEqual([entry["entry_id"] for entry in entries], [entry_id])
def test_learning_factors_reports_points_and_learnable(self):
with tempfile.TemporaryDirectory() as temp_dir:
from app.factor_history import FactorHistory
fh = FactorHistory(Path(temp_dir))
for i in range(3):
fh.record("macro_consumption", 3.0 + i, ts=f"2026-0{i+1}-01T00:00:00+00:00")
app = create_app({"TESTING": True, "SNAPSHOT": self.snapshot,
"FACTOR_HISTORY_DIR": Path(temp_dir)})
resp = app.test_client().get("/api/v1/learning/factors?min_points=2")
self.assertEqual(resp.status_code, 200)
body = resp.get_json()
self.assertEqual(body["min_points"], 2)
mc = next(r for r in body["factors"] if r["factor_key"] == "macro_consumption")
self.assertEqual(mc["n_points"], 3)
self.assertTrue(mc["learnable"])
self.assertEqual(mc["last_value"], 5.0)
# sorted by n_points desc: macro_consumption (3) should be first
self.assertEqual(body["factors"][0]["factor_key"], "macro_consumption")
def test_learning_factors_rejects_bad_min_points(self):
app = create_app({"TESTING": True, "SNAPSHOT": self.snapshot})
resp = app.test_client().get("/api/v1/learning/factors?min_points=abc")
self.assertEqual(resp.status_code, 400)
if __name__ == "__main__":
unittest.main()