kunthawat/set50-system
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

docs: record IRPC review verdict (passed) + open no-fixture-fallback tradeoff

Browse Source
This commit is contained in:
Kunthawat Greethong
2026-08-29 11:14:02 +07:00
parent 12b34929d7
commit 51400f20c7
1 changed files with 6 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
docs/engineering-log/2026-08-29-data-source-expansion-and-ui-fix.md
View File

@@ -54,6 +54,12 @@ and clean. Added:
- frontend theme card shows "กำไรสุทธิ IRPC 10.27%"
Full suite **368 tests OK**; frontend build clean; live dashboard refining_energy
surprise 0.764 driven partly by IRPC margin.
Independent review `deleg_474555e4` **passed: true** (parser/paren/value-key/wiring
all correct, no security/logic errors). Suggestion applied: comment noting
ebitda/roe are display-only. Author also flagged that a single upstream page
failure (strict `_fetch_with_cache` → DashboardError) takes down the whole board —
consistent with the documented no-fixture-fallback policy; left as an open
decision, not silently changed.
Deferred (feasibility blocked): REIC (JS SPA/XHR), EPPO (JS/WordPress), NBTC (403
anti-bot), PTTEP (JS shell), PTT/BCP (404/DNS). Need browser/XHR approach, not